Add overflow-wrap to CssSchema definition list #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven Strickroth <[email protected]>
csware
commented
Jan 30, 2024
| @@ -423,6 +423,8 @@ Property forKey(String propertyName) { | |||
| "auto", "inherit", "none"); | |||
| Set<String> overflowLiterals0 = Set.of( | |||
| "auto", "hidden", "inherit", "scroll", "visible"); | |||
| Set<String> overflowWrapLiterals0 = Set.of( | |||
| "normal", "break-word", "anywhere", "inherit"); | |||
There was a problem hiding this comment.
What about other valid values such as "initial" , "revert" , "revert-layer", "unset" ((listed as "global values" on https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap?
Thoase are also not listed for the other properties.
There was a problem hiding this comment.
I think revert and revert-layer were added before the last time this property list was thoroughly revamped. I don't quite understand the semantics, but I would worry about adding it everywhere that inherit appears in case it allows working around visual containment and event capturing measures like clipping, position, and overflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290