Update the maven-compiler-plugin to make the --release check work #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csware
changed the title
csware
commented
Jan 23, 2024
| @@ -185,11 +185,7 @@ application while protecting against XSS. | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-compiler-plugin</artifactId> | |||
| <version>3.3</version> | |||
| <configuration> | |||
| <source>9</source> | |||
There was a problem hiding this comment.
already set as properties above
mikesamuel
approved these changes
Feb 2, 2024
For the compiler --release check to work, we need a more recent maven-compiler-plugin version (at least 3.6). Signed-off-by: Sven Strickroth <[email protected]>
|
ATM JDK10 is required. I already have a branch that unbreaks JDK9 and unbreaks JDK8, cf. #301 (comment) and #301 (comment) I can open a PR as soon as PR #302 and PR #313 have been decided (becasue it will conflict with these changes) |
|
Maybe we should raise to JDK10 in pom.xml until we have fixes for JDK9... |
|
Ugh. JDK 9 is the new JDK 6. |
|
Closed in favor of PR #321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the compiler --release check to work, we need a more recent maven-compiler-plugin version (at least 3.6).
relates to issue #301