Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Support xxx-large and medium css font-size values. #294

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

subbudvk
Copy link
Contributor

@subbudvk subbudvk commented Nov 27, 2023

xxx-large and medium are valid css font-size values.

https://developer.mozilla.org/en-US/docs/Web/CSS/font-size

This PR Fixes #291

@subbudvk
Copy link
Contributor Author

@jmanico @mikesamuel

@Ashish-Singh-B
Copy link

Ashish-Singh-B commented Dec 6, 2023

@jmanico @mikesamuel @subbudvk Thanks for the help guys, what are next steps to get this merged and published

Copy link
Member

@jmanico jmanico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me

@Ashish-Singh-B
Copy link

Hi @mikesamuel , can you please merge this small changes and release a new version,
it seems there haven't been a new release for more than a year now, so it'll be great to have a new version with this changes

@mikesamuel mikesamuel merged commit 5b420f9 into OWASP:main Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xxx-large font-size is discarded when allowStyling() is used
4 participants