chromium: Enable Rust #782

MaxIhlenfeldt · 2024-01-22T12:00:18Z

This adds a dependency on OE's Rust recipe, as well as all the necessary changes to make Chromium successfully use that toolchain.

This change will also mean we don't support any Yocto release older than kirkstone, as that is the first release with Rust in OE that isn't EOL yet. Most notably, we will drop support for dunfell.

This adds a dependency on OE's Rust recipe, as well as all the necessary changes to make Chromium successfully use that toolchain. Signed-off-by: Max Ihlenfeldt <[email protected]>

MaxIhlenfeldt · 2024-01-22T12:10:24Z

Some comments:

@nrpt-m as always, testing would be greatly appreciated! As discussed, this patch will mean we don't support dunfell any more. Also, please use https://git.yoctoproject.org/meta-lts-mixins/log/?h=kirkstone/rust-1.68 for kirkstone. I suspect the build will still fail even with that mixin because the Rust version is too old; but we should confirm it before adding a mixin with a newer version.
iiuc, one usually doesn't depend on rust(-native) directly, but inherits from the cargo class. I chose not to do that because it created some problems (I'm not 100% sure what it was, but I think the libstd-rs libraries were still being installed despite the line in rust_%.bbappend). cc @rwmacleod (I think you are/were involved in meta-rust development?)
As soon as I get confirmation from someone else that the build works, I'll submit 0025-Make-toolchain_supports_rust_thin_lto-configurable.patch upstream. I've talked to danakj@, she seemed open to accepting it.

Signed-off-by: Max Ihlenfeldt <[email protected]>

rwmacleod · 2024-01-23T17:09:18Z

@MaxIhlenfeldt These days I'm mostly involved in Rust in trying to help @sundeep-kokkonda and @Yashinde145 so I've mentioned this thread to them and I see that Sundeep cloned meta-browser so he may reply to your question.

Also, for kirkstone, @g-scott-murray mentioned today that he is working on an update to (1.70?) of the rust mixin layer and that they are interested in chromium for AGL as you might already know.

nrpt-m · 2024-01-23T17:36:43Z

Some comments:

@nrpt-m as always, testing would be greatly appreciated! As discussed, this patch will mean we don't support dunfell any more. Also, please use https://git.yoctoproject.org/meta-lts-mixins/log/?h=kirkstone/rust-1.68 for kirkstone. I suspect the build will still fail even with that mixin because the Rust version is too old; but we should confirm it before adding a mixin with a newer version.

@MaxIhlenfeldt ,
Have successfully compiled the current chromium-120.0.6099.224 version after applying the patches mentioned in this PR. Have used poky/kirkstone source and all other required layers in kirkstone branch along with this https://git.yoctoproject.org/meta-lts-mixins/log/?h=kirkstone/rust-1.68 layer.

Have attached the console.log file as well.
console-latest.log

MaxIhlenfeldt · 2024-01-24T10:32:26Z

Great to hear it works with the 1.68 mixin on kirkstone already!

MaxIhlenfeldt · 2024-01-24T10:37:24Z

One note, as Rust is a hard requirement for Chromium 121, it'd be easiest to have this PR merged before I start working on the update. I'd also like to do a separate PR that removes all dunfell-specific patches first. But if it takes too long to merge this, I can start working on the update already.

MaxIhlenfeldt · 2024-01-25T10:57:27Z

The toolchain_supports_rust_thin_lto patch has been accepted upstream as https://crrev.com/c/5233602, so I moved the patch file to files/backports and updated its Upstream-Status.

MaxIhlenfeldt · 2024-01-30T12:39:14Z

@kraj @rakuco gentle ping as merging this before starting to work on the (already released) 121 update would be best.

kraj

lgtm

rakuco

Sorry for the delay here. I know very little about Rust and how its toolchain works, so I can't really review the changes here but fully trust you and the others on this one.

Thanks for all the hard work, and I'm glad to see dunfell support finally going away!

rakuco · 2024-01-30T18:09:48Z

meta-chromium/recipes-browser/chromium/chromium-gn.inc

    virtual/libgl \
 "
-DEPEND:append:runtime-llvm = " compiler-rt-native libcxx-native"


Out of curiosity, does this mean that this line was completely broken before?

I think it was working before, but when Rust is enabled Chromium needs to link against the target clang runtime libraries, see https://source.chromium.org/chromium/chromium/src/+/main:build/config/compiler/BUILD.gn;l=1660-1668;drc=ab6484854e1fb7a38160336acc6b34b6ecdda628.

Right, but does it mean the previous variable name was incorrect and therefore the assignment did not have any effect?

Oh, right, I overlooked that I changed that as well. Yes, that might have indeed been the case 😅

Interesting. That might explain some of the bug reports we've had over the years :-) Glad to see it's been fixed.

rakuco · 2024-01-30T18:21:24Z

This change will also mean we don't support any Yocto release older than kirkstone, as that is the first release with Rust in OE that isn't EOL yet. Most notably, we will drop support for dunfell.

@otavio @kraj @MaxIhlenfeldt we'd normally create a "dunfell" branch at the commit ea731e8; I wonder if it makes sense given dunfell as a whole is going EoL in just a few months.

otavio · 2024-01-30T18:38:25Z

I am not opposed as this is the last working version.

rakuco · 2024-01-30T18:55:52Z

I am not opposed as this is the last working version.

Done!

Fixes OSSystems#792. Build and patch changes: ------------------------ In OSSystems#782, we decided to depend on rust instead of libstd-rs, because the latter didn't include libprofiler_builtins and also used a naming scheme that trips up Chromium. However, in OSSystems#791 we decided to patch Chromium so that it doesn't need libprofiler_builtins any more, because the master version of the rust recipe also doesn't include it. Finally, while investigating OSSystems#792 it turned out that our approach breaks as soon as we have something that depends on libstd-rs in our dependency graph. In that scenario, both libstd-rs and rust (the latter due to our bbappend file) install Rust libraries to /usr/lib/rustlib. This first leads to Chromium build system errors (due to libstd-rs's naming scheme), and after fixing these to Rust compiler errors due to multiple versions being present. The conclusion is now that we can depend on libstd-rs we should do so. This only requires a small change to Chromium's Rust build scripts to adapt them to the slightly different naming scheme. License changes: ---------------- Added licenses: none. Removed licenses: none. Updated licenses: none. Test-built: ----------- * chromium-wayland: - nanbield, clang, MACHINE=qemuarm64 * chromium-x11: - master, clang, MACHINE=qemuarm Signed-off-by: Max Ihlenfeldt <[email protected]>

chromium: Depend on libstd-rs instead of rust Fixes #792. Build and patch changes: ------------------------ In #782, we decided to depend on rust instead of libstd-rs, because the latter didn't include libprofiler_builtins and also used a naming scheme that trips up Chromium. However, in #791 we decided to patch Chromium so that it doesn't need libprofiler_builtins any more, because the master version of the rust recipe also doesn't include it. Finally, while investigating #792 it turned out that our approach breaks as soon as we have something that depends on libstd-rs in our dependency graph. In that scenario, both libstd-rs and rust (the latter due to our bbappend file) install Rust libraries to /usr/lib/rustlib. This first leads to Chromium build system errors (due to libstd-rs's naming scheme), and after fixing these to Rust compiler errors due to multiple versions being present. The conclusion is now that we can depend on libstd-rs we should do so. This only requires a small change to Chromium's Rust build scripts to adapt them to the slightly different naming scheme. Also, while we're already reworking our Rust setup, we can remove the remaining part of our bbappend for the rust recipe and instead inherit the `rust-common` class, thereby inheriting `rust-target-config` (which needs stuff from `rust-common`). This means we get the `target.json` files the Rust compiler needs installed in the directory pointed to by the `RUST_TARGET_PATH` environment variable. License changes: ---------------- Added licenses: none. Removed licenses: none. Updated licenses: none. Test-built: ----------- * chromium-wayland: - nanbield, clang, MACHINE=qemuarm64 * chromium-x11: - master, clang, MACHINE=qemuarm Signed-off-by: Max Ihlenfeldt <[email protected]>

chromium: Enable Rust

5371eb7

This adds a dependency on OE's Rust recipe, as well as all the necessary changes to make Chromium successfully use that toolchain. Signed-off-by: Max Ihlenfeldt <[email protected]>

MaxIhlenfeldt requested review from rakuco and kraj January 22, 2024 12:00

MaxIhlenfeldt linked an issue Jan 22, 2024 that may be closed by this pull request

chromium: Prepare for Rust. #723

Closed

MaxIhlenfeldt mentioned this pull request Jan 22, 2024

chromium: Prepare for Rust. #723

Closed

update LAYERSERIES_COMPAT

1dbc2f8

Signed-off-by: Max Ihlenfeldt <[email protected]>

move toolchain_supports_rust_thin_lto patch to backports

a3cefee

otavio approved these changes Jan 30, 2024

View reviewed changes

kraj approved these changes Jan 30, 2024

View reviewed changes

otavio merged commit 701272a into OSSystems:master Jan 30, 2024

rakuco mentioned this pull request Jan 30, 2024

meta-browser: Drop gatesgarth support? #559

Closed

rakuco reviewed Jan 30, 2024

View reviewed changes

MaxIhlenfeldt mentioned this pull request Mar 21, 2024

18.1.1 clang compilation issue #794

Closed

MaxIhlenfeldt mentioned this pull request May 8, 2024

chromium: Depend on libstd-rs instead of rust #809

Merged

MaxIhlenfeldt mentioned this pull request Dec 4, 2024

[Kirkstone] cross dependency with meta-rust and meta-lts-mixins #805

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chromium: Enable Rust #782

chromium: Enable Rust #782

MaxIhlenfeldt commented Jan 22, 2024 •

edited

Loading

MaxIhlenfeldt commented Jan 22, 2024

rwmacleod commented Jan 23, 2024

nrpt-m commented Jan 23, 2024

MaxIhlenfeldt commented Jan 24, 2024

MaxIhlenfeldt commented Jan 24, 2024

MaxIhlenfeldt commented Jan 25, 2024

MaxIhlenfeldt commented Jan 30, 2024

kraj left a comment

rakuco left a comment

rakuco Jan 30, 2024

MaxIhlenfeldt Jan 31, 2024

rakuco Jan 31, 2024

MaxIhlenfeldt Jan 31, 2024

rakuco Jan 31, 2024

rakuco commented Jan 30, 2024

otavio commented Jan 30, 2024

rakuco commented Jan 30, 2024

chromium: Enable Rust #782

chromium: Enable Rust #782

Conversation

MaxIhlenfeldt commented Jan 22, 2024 • edited Loading

MaxIhlenfeldt commented Jan 22, 2024

rwmacleod commented Jan 23, 2024

nrpt-m commented Jan 23, 2024

MaxIhlenfeldt commented Jan 24, 2024

MaxIhlenfeldt commented Jan 24, 2024

MaxIhlenfeldt commented Jan 25, 2024

MaxIhlenfeldt commented Jan 30, 2024

kraj left a comment

Choose a reason for hiding this comment

rakuco left a comment

Choose a reason for hiding this comment

rakuco Jan 30, 2024

Choose a reason for hiding this comment

MaxIhlenfeldt Jan 31, 2024

Choose a reason for hiding this comment

rakuco Jan 31, 2024

Choose a reason for hiding this comment

MaxIhlenfeldt Jan 31, 2024

Choose a reason for hiding this comment

rakuco Jan 31, 2024

Choose a reason for hiding this comment

rakuco commented Jan 30, 2024

otavio commented Jan 30, 2024

rakuco commented Jan 30, 2024

MaxIhlenfeldt commented Jan 22, 2024 •

edited

Loading