Skip to content

Commit

Permalink
chromium: Update to 114.0.5735.133
Browse files Browse the repository at this point in the history
Release notes:
    https://chromereleases.googleblog.com/2023/05/stable-channel-update-for-desktop_30.html
    https://chromereleases.googleblog.com/2023/06/stable-channel-update-for-desktop.html
    https://chromereleases.googleblog.com/2023/06/stable-channel-update-for-desktop_13.html

Build and patch changes:
------------------------

Drop 0024-Backport-Fix-erroneous-SupportsOstreamOperator-int-i.patch and
0025-Backport-Do-not-use-std-monospace-for-absl-variant.patch as they
are included upstream now.

Add one more fixed defaulted `operator==` to
0018-Only-default-operator-on-declaration.patch.

Modify 0019-Backport-constexpr-std-string-fixes.patch and
0022-Backport-Avoid-capturing-structured-bindings.patch to work with 114
instead of 113.

Add some more needed `typename`s to 0021-Add-missing-typename-s.patch.

Add 0027-Don-t-pass-disable-auto-upgrade-debug-info-to-linker.patch to
fix a build error due to upstream using an lld CLI option that's not yet
available for us.

Add 0028-Avoid-capturing-structured-bindings.patch to fix build errors
due to a C++20-specific feature being used with clang < 16.

Add 0029-Backport-IWYU-for-translate-TranslateUiLanguagesMana.patch to
fix a build error due to a missing include.

Add 0030-Backport-Avoid-operator-which-is-C-20-specific.patch to fix
build errors due to C++-specific features.

Rebase remaining patches.

License changes:
----------------

Added licenses:
  * third_party/android_deps/libs/org_jetbrains_kotlinx_kotlinx_coroutines_guava/LICENSE
  - https://chromium-review.googlesource.com/c/chromium/src/+/4474588

Removed licenses:
  * third_party/android_deps/libs/com_google_android_gms_play_services_fido/LICENSE
  - https://chromium-review.googlesource.com/c/chromium/src/+/4367668

  * third_party/web-animations-js/LICENSE
  - https://chromium-review.googlesource.com/c/chromium/src/+/4382315

Updated licenses:
  * third_party/d3/src/LICENSE
  - https://chromium-review.googlesource.com/c/chromium/src/+/4408903

  * third_party/eigen3/LICENSE
  - https://chromium-review.googlesource.com/c/chromium/src/+/4522046

  * third_party/harfbuzz-ng/src/COPYING
  - https://chromium-review.googlesource.com/c/chromium/src/+/4464912

  * third_party/openscreen/src/LICENSE
  - https://chromium-review.googlesource.com/c/openscreen/+/4380180

Test-built:
-----------

* chromium-ozone-wayland:
 - master, clang,     MACHINE=qemux86-64
 - mickledore, clang, MACHINE=qemux86-64, qemuarm64
 - kirkstone, clang,  MACHINE=raspberrypi4-64, qemux86-64
 - dunfell, clang**,  MACHINE=qemux86-64

* chromium-x11
 - master, clang,     MACHINE=raspberrypi4-64, qemux86-64, qemuarm64, qemuarm
 - mickledore, clang, MACHINE=raspberrypi4-64, qemux86-64, qemuarm64, qemuarm
 - kirkstone, clang,  MACHINE=raspberrypi4-64, qemux86-64, qemuarm64, qemuarm
 - dunfell, clang**,  MACHINE=raspberrypi4-64***, qemux86-64, qemuarm64, qemuarm

** Please note that Chromium requires below set-up when on dunfell
branch.
- The clang version to be >= 12 and for that, use the latest
  meta-clang/dunfell-clang12 branch.
- Require the latest meta-oe with Nodejs 14.x support.
- Add the PREFERRED_VERSION_nodejs-native = "14.%" in conf/local.conf
  file.

*** Please note that there currently is a problem on RPi4/dunfell where
Chromium's network service crashes.

Signed-off-by: Max Ihlenfeldt <[email protected]>
  • Loading branch information
MaxIhlenfeldt committed Jun 26, 2023
1 parent b279a4d commit 97c2690
Show file tree
Hide file tree
Showing 23 changed files with 375 additions and 1,250 deletions.
6 changes: 4 additions & 2 deletions meta-chromium/recipes-browser/chromium/chromium-gn.inc
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,11 @@ SRC_URI += " \
file://0021-Add-missing-typename-s.patch \
file://0022-Backport-Avoid-capturing-structured-bindings.patch \
file://0023-Backport-IWYU-for-translate-TranslateUILanguagesMana.patch \
file://0024-Backport-Fix-erroneous-SupportsOstreamOperator-int-i.patch \
file://0025-Backport-Do-not-use-std-monospace-for-absl-variant.patch \
file://0026-Backport-std-string-ends_with-is-C-20.-Use-base-Ends.patch \
file://0027-Don-t-pass-disable-auto-upgrade-debug-info-to-linker.patch \
file://0028-Avoid-capturing-structured-bindings.patch \
file://0029-Backport-IWYU-for-translate-TranslateUiLanguagesMana.patch \
file://0030-Backport-Avoid-operator-which-is-C-20-specific.patch \
"

SRC_URI:append:libc-musl = "\
Expand Down
13 changes: 6 additions & 7 deletions meta-chromium/recipes-browser/chromium/chromium.inc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ HOMEPAGE = "https://www.chromium.org/Home"
CVE_PRODUCT = "chromium:chromium google:chrome"

SRC_URI = "https://commondatastorage.googleapis.com/chromium-browser-official/chromium-${PV}.tar.xz"
SRC_URI[sha256sum] = "0def7cd594304d7675821d42a4207377af98e321a78a91ee5200aea55adc2d93"
SRC_URI[sha256sum] = "8289ec1ec9e2540313af10bcf97721ec560789c931fc0583a2f5a545f223d262"

S = "${WORKDIR}/chromium-${PV}"

Expand Down Expand Up @@ -147,7 +147,6 @@ LIC_FILES_CHKSUM = "\
file://${S}/third_party/android_deps/libs/com_google_android_gms_play_services_cast_framework/LICENSE;md5=6688c3d596b2e35dd1928d1ffdf5a9e2 \
file://${S}/third_party/android_deps/libs/com_google_android_gms_play_services_clearcut/LICENSE;md5=32c019d8c1f8222a8aad9c3e1f1d2d10 \
file://${S}/third_party/android_deps/libs/com_google_android_gms_play_services_cloud_messaging/LICENSE;md5=fb1c3d71ca3681654ec1604b10fc1ace \
file://${S}/third_party/android_deps/libs/com_google_android_gms_play_services_fido/LICENSE;md5=8da3462ecfc5c138a49a7b5ac05abf09 \
file://${S}/third_party/android_deps/libs/com_google_android_gms_play_services_flags/LICENSE;md5=92b728c587a67a1b9577e9ca141ca520 \
file://${S}/third_party/android_deps/libs/com_google_android_gms_play_services_gcm/LICENSE;md5=92b728c587a67a1b9577e9ca141ca520 \
file://${S}/third_party/android_deps/libs/com_google_android_gms_play_services_iid/LICENSE;md5=05fc50851d6d550ef2bb400b326353f0 \
Expand Down Expand Up @@ -198,6 +197,7 @@ LIC_FILES_CHKSUM = "\
file://${S}/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib_jdk8/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/android_deps/libs/org_jetbrains_kotlinx_kotlinx_coroutines_android/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/android_deps/libs/org_jetbrains_kotlinx_kotlinx_coroutines_core_jvm/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/android_deps/libs/org_jetbrains_kotlinx_kotlinx_coroutines_guava/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/android_media/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/android_opengl/LICENSE;md5=d10e92761a860d4113a7a525c78daf13 \
file://${S}/third_party/android_provider/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
Expand Down Expand Up @@ -232,7 +232,7 @@ LIC_FILES_CHKSUM = "\
file://${S}/third_party/crc32c/src/LICENSE;md5=e9ed01b5e5ac9eae23fc2bb33701220c \
file://${S}/third_party/cros-components/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/crubit/LICENSE;md5=e8237eb3ff53402dada6d65b7640b60b \
file://${S}/third_party/d3/src/LICENSE;md5=0679931d76eb2f1dd1915249da84a722 \
file://${S}/third_party/d3/src/LICENSE;md5=fcc83e5a00c3ea5885051b46163bd453 \
file://${S}/third_party/dav1d/LICENSE;md5=59cb7015cbeea4a8675b9bdb657d41b3 \
file://${S}/third_party/dawn/LICENSE;md5=94758054e79f4a16d45043dfa6248541 \
file://${S}/third_party/decklink/LICENSE;md5=85b197f7b7b1ef270b01a1b6377be50e \
Expand All @@ -250,7 +250,7 @@ LIC_FILES_CHKSUM = "\
file://${S}/third_party/devtools-frontend/src/front_end/third_party/wasmparser/package/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93 \
file://${S}/third_party/distributed_point_functions/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/dom_distiller_js/LICENSE;md5=6cd778870ce5c0c08c8e16fbdf378532 \
file://${S}/third_party/eigen3/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/eigen3/LICENSE;md5=48a3fe23ed1353e0995dadfda05ffdb6 \
file://${S}/third_party/emoji-metadata/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/emoji-segmenter/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/expat/src/expat/COPYING;md5=7b3b078238d0901d3b339289117cb7fb \
Expand All @@ -275,7 +275,7 @@ LIC_FILES_CHKSUM = "\
file://${S}/third_party/grpc-java/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/grpc/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/gvr-android-sdk/LICENSE;md5=634fdf826e0846931133dca5785f59b8 \
file://${S}/third_party/harfbuzz-ng/src/COPYING;md5=6ee0f16281694fb6aa689cca1e0fb3da \
file://${S}/third_party/harfbuzz-ng/src/COPYING;md5=b98429b8e8e3c2a67cfef01e99e4893d \
file://${S}/third_party/highway/LICENSE;md5=2b42edef8fa55315f34f2370b4715ca9 \
file://${S}/third_party/hunspell/COPYING.MPL;md5=bfe1f75d606912a4111c90743d6c7325 \
file://${S}/third_party/hyphenation-patterns/LICENSE;md5=23d9bd4878e6f3669ed39b2095b01c13 \
Expand Down Expand Up @@ -339,7 +339,7 @@ LIC_FILES_CHKSUM = "\
file://${S}/third_party/omnibox_proto/LICENSE;md5=9956e3ce49f0eea45461cec47a5f96b0 \
file://${S}/third_party/one_euro_filter/LICENSE;md5=5b4d092181a412ae42c63e7fc1e53366 \
file://${S}/third_party/openh264/src/LICENSE;md5=bb6d3771da6a07d33fd50d4d9aa73bcf \
file://${S}/third_party/openscreen/src/LICENSE;md5=d5fead7a94377fb7b73964d9144c6cbb \
file://${S}/third_party/openscreen/src/LICENSE;md5=5ff965dafeb8e99de6698664decb9e89 \
file://${S}/third_party/opus/src/COPYING;md5=e304cdf74c2a1b0a33a5084c128a23a3 \
file://${S}/third_party/ots/LICENSE;md5=e06eff2aa65b917034a81599bea73dc4 \
file://${S}/third_party/pdfium/LICENSE;md5=c93507531cc9bb8e24a05f2a1a4036c7 \
Expand Down Expand Up @@ -397,7 +397,6 @@ LIC_FILES_CHKSUM = "\
file://${S}/third_party/vulkan_memory_allocator/LICENSE.txt;md5=28469cb09e41bc708efbb6a69fb39a29 \
file://${S}/third_party/wayland-protocols/src/COPYING;md5=c7b12b6702da38ca028ace54aae3d484 \
file://${S}/third_party/wayland/src/COPYING;md5=b31d8f53b6aaf2b4985d7dd7810a70d1 \
file://${S}/third_party/web-animations-js/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
file://${S}/third_party/webrtc/LICENSE;md5=ad296492125bc71530d06234d9bfebe0 \
file://${S}/third_party/weston/LICENSE;md5=58164c3e354cc1d2f50a79ea98eb2b15 \
file://${S}/third_party/woff2/LICENSE;md5=027c71da9e4664fdf192e6ec615f4d18 \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Signed-off-by: Maksim Sisov <[email protected]>
2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index d3adf9735ca95..bbe807fdc7b04 100644
index 28c2255ba8090..d740c7caf9427 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -680,7 +680,7 @@ config("compiler") {
Expand All @@ -29,7 +29,7 @@ index d3adf9735ca95..bbe807fdc7b04 100644
"-mllvm:-import-instr-limit=$import_instr_limit",
"/lldltocache:" +
rebase_path("$root_out_dir/thinlto-cache", root_build_dir),
@@ -693,11 +693,11 @@ config("compiler") {
@@ -694,11 +694,11 @@ config("compiler") {
# usage in crbug.com/1038040. Note this will increase build time in
# Chrome OS.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ Rebased-by: Randy MacLeod <[email protected]>
1 file changed, 38 deletions(-)

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index bbe807fdc7b04..ca70a35b4d269 100644
index d740c7caf9427..8f13f37d347cc 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -996,11 +996,6 @@ config("compiler_cpu_abi") {
@@ -1005,11 +1005,6 @@ config("compiler_cpu_abi") {
]
}
} else if (current_cpu == "arm") {
Expand All @@ -36,7 +36,7 @@ index bbe807fdc7b04..ca70a35b4d269 100644
if (!is_nacl) {
cflags += [
"-march=$arm_arch",
@@ -1010,12 +1005,6 @@ config("compiler_cpu_abi") {
@@ -1019,12 +1014,6 @@ config("compiler_cpu_abi") {
if (arm_tune != "") {
cflags += [ "-mtune=$arm_tune" ]
}
Expand All @@ -49,7 +49,7 @@ index bbe807fdc7b04..ca70a35b4d269 100644
} else if (current_cpu == "mipsel" && !is_nacl) {
ldflags += [ "-Wl,--hash-style=sysv" ]
if (custom_toolchain == "") {
@@ -1023,9 +1012,6 @@ config("compiler_cpu_abi") {
@@ -1032,9 +1021,6 @@ config("compiler_cpu_abi") {
if (is_android) {
cflags += [ "--target=mipsel-linux-android" ]
ldflags += [ "--target=mipsel-linux-android" ]
Expand All @@ -59,7 +59,7 @@ index bbe807fdc7b04..ca70a35b4d269 100644
}
} else {
cflags += [ "-EL" ]
@@ -1105,8 +1091,6 @@ config("compiler_cpu_abi") {
@@ -1114,8 +1100,6 @@ config("compiler_cpu_abi") {
ldflags += [ "-Wl,--hash-style=sysv" ]
if (custom_toolchain == "") {
if (is_clang) {
Expand All @@ -68,7 +68,7 @@ index bbe807fdc7b04..ca70a35b4d269 100644
} else {
cflags += [ "-EB" ]
ldflags += [ "-EB" ]
@@ -1154,9 +1138,6 @@ config("compiler_cpu_abi") {
@@ -1163,9 +1147,6 @@ config("compiler_cpu_abi") {
if (is_android) {
cflags += [ "--target=mips64el-linux-android" ]
ldflags += [ "--target=mips64el-linux-android" ]
Expand All @@ -78,7 +78,7 @@ index bbe807fdc7b04..ca70a35b4d269 100644
}
} else {
cflags += [
@@ -1214,8 +1195,6 @@ config("compiler_cpu_abi") {
@@ -1223,8 +1204,6 @@ config("compiler_cpu_abi") {
ldflags += [ "-Wl,--hash-style=sysv" ]
if (custom_toolchain == "") {
if (is_clang) {
Expand All @@ -87,7 +87,7 @@ index bbe807fdc7b04..ca70a35b4d269 100644
} else {
cflags += [
"-EB",
@@ -1378,23 +1357,6 @@ config("compiler_deterministic") {
@@ -1387,23 +1366,6 @@ config("compiler_deterministic") {
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,34 +29,34 @@ index 52504f4f6f009..40425d63454f3 100644
"root_out_dir") +
"/v8_context_snapshot_generator",
diff --git a/v8/BUILD.gn b/v8/BUILD.gn
index 8f937794079..3f4071e0c88 100644
index 5cda664fdde..1b6919e71ea 100644
--- a/v8/BUILD.gn
+++ b/v8/BUILD.gn
@@ -2012,6 +2012,7 @@ template("run_torque") {
@@ -2055,6 +2055,7 @@ template("run_torque") {
}

args = [
+ "./v8-qemu-wrapper.sh",
"./" + rebase_path(
get_label_info(":torque($toolchain)", "root_out_dir") + "/torque",
root_build_dir),
@@ -2144,6 +2145,7 @@ action("generate_bytecode_builtins_list") {
@@ -2187,6 +2188,7 @@ action("generate_bytecode_builtins_list") {
outputs = [ "$target_gen_dir/builtins-generated/bytecodes-builtins-list.h" ]
deps = [ ":bytecode_builtins_list_generator($v8_generator_toolchain)" ]
args = [
+ "./v8-qemu-wrapper.sh",
"./" + rebase_path(
get_label_info(
":bytecode_builtins_list_generator($v8_generator_toolchain)",
@@ -2183,6 +2185,7 @@ template("run_mksnapshot") {
@@ -2226,6 +2228,7 @@ template("run_mksnapshot") {
data = []

args = [
+ "./v8-qemu-wrapper.sh",
"./" + rebase_path(get_label_info(":mksnapshot($v8_snapshot_toolchain)",
"root_out_dir") + "/mksnapshot",
root_build_dir),
@@ -6546,6 +6549,7 @@ if (v8_enable_i18n_support) {
@@ -6600,6 +6603,7 @@ if (v8_enable_i18n_support) {
outputs = [ output_file ]

args = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ Signed-off-by: Khem Raj <[email protected]>
1 file changed, 10 deletions(-)

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index ca70a35b4d269..a789a5aa0178c 100644
index 8f13f37d347cc..e3f22ce0a471b 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -995,16 +995,6 @@ config("compiler_cpu_abi") {
@@ -1004,16 +1004,6 @@ config("compiler_cpu_abi") {
"-msse3",
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ Signed-off-by: Randy MacLeod <[email protected]>
1 file changed, 5 insertions(+)

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index a789a5aa0178c..fe0f989625879 100644
index e3f22ce0a471b..19badda7d644b 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1583,6 +1583,11 @@ config("default_warnings") {
@@ -1592,6 +1592,11 @@ config("default_warnings") {
cflags += [
"-Wenum-compare-conditional",

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ Signed-off-by: Randy MacLeod <[email protected]>
2 files changed, 4 insertions(+)

diff --git a/base/BUILD.gn b/base/BUILD.gn
index 4d8087f0d747e..a3d75f04f6aff 100644
index 8417fcda40d49..678c1b736d86f 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1105,7 +1105,9 @@ component("base") {
@@ -1100,7 +1100,9 @@ component("base") {
# Needed for <atomic> if using newer C++ library than sysroot, except if
# building inside the cros_sdk environment - use host_toolchain as a
# more robust check for this.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,18 @@ Signed-off-by: Max Ihlenfeldt <[email protected]>
2 files changed, 11 insertions(+), 17 deletions(-)

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index fe0f989625879..1259819238f17 100644
index 19badda7d644b..88e4bbfc4f8c5 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1286,7 +1286,6 @@ config("compiler_codegen") {
@@ -1295,7 +1295,6 @@ config("compiler_codegen") {
config("compiler_deterministic") {
cflags = []
ldflags = []
- swiftflags = []

# Eliminate build metadata (__DATE__, __TIME__ and __TIMESTAMP__) for
# deterministic build. See https://crbug.com/314403
@@ -1315,20 +1314,12 @@ config("compiler_deterministic") {
@@ -1324,20 +1323,12 @@ config("compiler_deterministic") {
# different build directory like "out/feature_a" and "out/feature_b" if
# we build same files with same compile flag.
# Other paths are already given in relative, no need to normalize them.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ Signed-off-by: Randy MacLeod <[email protected]>
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 1259819238f17..4ae9a6e9e4df1 100644
index 88e4bbfc4f8c5..bbfe6cb53ca2a 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -816,9 +816,11 @@ config("compiler") {
@@ -825,9 +825,11 @@ config("compiler") {
# * Apple platforms (e.g. MacOS, iPhone, iPad) aren't supported because xcode
# lldb doesn't have the needed changes yet.
# TODO(crbug.com/1379070): Remove if the upstream default ever changes.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,13 @@ Signed-off-by: Max Ihlenfeldt <[email protected]>
.../core/browser/affiliation/affiliation_fetcher_base.cc | 3 ---
.../core/browser/affiliation/affiliation_fetcher_base.h | 3 ---
.../core/browser/affiliation/affiliation_fetcher_interface.h | 2 +-
.../password_manager/core/browser/passkey_credential.cc | 3 ---
.../password_manager/core/browser/passkey_credential.h | 5 +----
printing/page_setup.cc | 4 ----
printing/page_setup.h | 4 ++--
printing/print_settings.cc | 5 -----
printing/print_settings.h | 4 ++--
7 files changed, 5 insertions(+), 20 deletions(-)
9 files changed, 6 insertions(+), 27 deletions(-)

diff --git a/components/password_manager/core/browser/affiliation/affiliation_fetcher_base.cc b/components/password_manager/core/browser/affiliation/affiliation_fetcher_base.cc
index 5d5b95e0d787a..3a499529885be 100644
Expand Down Expand Up @@ -60,6 +62,41 @@ index 5bf889f5d940d..946eabe8dce6e 100644
};

AffiliationFetcherInterface() = default;
diff --git a/components/password_manager/core/browser/passkey_credential.cc b/components/password_manager/core/browser/passkey_credential.cc
index a775f1150d07c..6890826570f41 100644
--- a/components/password_manager/core/browser/passkey_credential.cc
+++ b/components/password_manager/core/browser/passkey_credential.cc
@@ -46,7 +46,4 @@ int PasskeyCredential::GetAuthenticatorLabel() const {
}
}

-bool operator==(const PasskeyCredential& lhs,
- const PasskeyCredential& rhs) = default;
-
} // namespace password_manager
diff --git a/components/password_manager/core/browser/passkey_credential.h b/components/password_manager/core/browser/passkey_credential.h
index 7bf384bd7ff40..2573132d0ee3c 100644
--- a/components/password_manager/core/browser/passkey_credential.h
+++ b/components/password_manager/core/browser/passkey_credential.h
@@ -48,8 +48,7 @@ class PasskeyCredential {
const std::string& display_name() const { return display_name_; }

private:
- friend bool operator==(const PasskeyCredential& lhs,
- const PasskeyCredential& rhs);
+ bool operator==(const PasskeyCredential& other) const = default;

// Authenticator type this passkey belongs to.
Source source_;
@@ -75,8 +74,6 @@ class PasskeyCredential {
std::string display_name_;
};

-bool operator==(const PasskeyCredential& lhs, const PasskeyCredential& rhs);
-
} // namespace password_manager

#endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSKEY_CREDENTIAL_H_
diff --git a/printing/page_setup.cc b/printing/page_setup.cc
index c104f44cdc6b0..93d3d60078aa0 100644
--- a/printing/page_setup.cc
Expand Down
Loading

0 comments on commit 97c2690

Please sign in to comment.