dbfopen: fix possible memory leaks when using realloc #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found the build process very confusing and instructions from README were I believe of older versions. I confess that my autoconf knowledge isn't great. Had to try lot of things before able to build the repository. Maybe, I'll open a different PR for that. Tests done:
Let me know if there are any more tests I can do. Thanks. |
rouault
reviewed
Oct 29, 2024
ymdatta
force-pushed
the
master
branch
2 times, most recently
from
80f78f7
to
b7432a6
Compare
|
Changes:
|
rouault
requested changes
Nov 1, 2024
| char *, realloc(psDBF->pszHeader, psDBF->nFields * XBASE_FLDHDR_SZ)); | ||
|
|
||
| if (!psDBF_char_realloc_ptr) | ||
| { | ||
| return FALSE; |
There was a problem hiding this comment.
there would be much more work to restore the psDBF state to a consistente state... I'm afraid that the best in that method would be to just "assert(false); return FALSE;" on failed memory allocations. Probably the same in DBFAlterFieldDefn()
Fixes OSGeo#165 Signed-off-by: Mohan Yelugoti <[email protected]>
rouault
reviewed
Nov 1, 2024
|
@thbeu your review would be appreciated |
Co-authored-by: Even Rouault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165