wxGUI: Fix various typos in comments, strings, and methods #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GUI
veroandreo
reviewed
Nov 18, 2024
veroandreo
approved these changes
Nov 18, 2024
neteler
added a commit
that referenced
this pull request
Nov 21, 2024
This PR de-duplicates the PO message files (currently the compilation is broken, apparently introduced in #4710), using ``` cd locale/po/ for i in $(ls grass*.po); do msguniq --use-first ${i} > $i.tmp rm -f ${i} mv $i.tmp ${i} done ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by fixing the typo of "circle" (instead of "cricle") as I observed in this PR and that @petrasovaa confirmed that for GUI, we don't guaranty compatibility of our function names #4693 (comment)
But then I continued, and ended up opening every file in the gui/ folder, and skimming through the unknown words of cspell for real typos, without any other setup. When there was a possibility of multiple spellings, I selected the en-US variation for consistency.
It is not exhaustive (i.e., license vs licence), but it is a good start.
When changing a localized string, I also applied the fixes in the translation files.
For the changes in the translated files, I verified that the template had been fixed. If the fixed msgid already existed and contained exactly the same string, I removed the wrong string (that would be a duplicate). In the first commits of the PR, there is a translation change for "contiguous" that was already fixed, and the only file that didn't have the exact same translation was locale/po/grasswxpy_ru.po, so both were kept. That's why 4 translation files have each 5 removed lines instead of fixes.