lib/vector/Vlib: Initialize variable before using it in write_sfa module #4696
Conversation
In `V2__add_line_to_topo_sfa` function which is only compiled when `HAVE_OGR` or `HAVE_POSTGRES` is defined, `first` variable is used without being initialized, which is undefined behavior. Based on the context, initialize `first` to `TRUE`, so that we first copy and then extend a box. This was found using cppcheck tool. Signed-off-by: Mohan Yelugoti <[email protected]>
github-actions
bot
added
vector
|
This PR was merged with 91d652f, but remained open !!?? |
|
Weird indeed, there's no active incident on the GitHub status page. I see the commit on main, but I didn't receive an email of the merged pull request. Was it pushed manually, not by the button in the web UI? |
|
Weird indeed, there's no active incident on the GitHub status page. I see the commit on main, but I didn't receive an email of the merged pull request. Was it pushed manually, not by the button in the web UI? Only 3-4 people have these push permissions as override |
|
I didn't receive any email either. I believe it was pushed manually. Or did we hit a bug on Github? 😄 |
|
I didn't push it. |
|
I hit the merge button, but only later saw this was still open. |
|
I didn't do anything, see my fork commit history: https://github.com/neteler/grass/commits/main/ |
|
I looked at the OSGeo gitea and the committer is GitHub, just like other PRs, unlike the pushes in releasebranch_8_4. So must be a GitHub glitch.. |
In
V2__add_line_to_topo_sfafunction which is only compiled whenHAVE_OGRorHAVE_POSTGRESis defined,firstvariable is used without being initialized, which is undefined behavior.Based on the context, initialize
firsttoTRUE, so that we first copy and then extend a box.This was found using cppcheck tool.