Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.watershed: Fix Resource Leak issue #4687

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

ShubhamDesai
Copy link
Contributor

This pull request fixes issue identified by coverity scan (CID : 1207844)
Used G_free() to fix the issue.

@github-actions github-actions bot added raster Related to raster data processing C Related code is in C module labels Nov 11, 2024
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this aims to address CID: 1207847, but please also address here 1207844 and 1207845.

@ShubhamDesai
Copy link
Contributor Author

I think this aims to address CID: 1207847, but please also address here 1207844 and 1207845.

done.

@echoix echoix requested a review from nilason November 12, 2024 23:53
@echoix echoix dismissed nilason’s stale review November 19, 2024 12:50

Author addressed changes, new review needed

@echoix echoix merged commit 29bb77b into OSGeo:main Nov 23, 2024
26 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C module raster Related to raster data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants