lib: Updated __cmp__ method for Python3 functionality #4684
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arohanajit
changed the title
|
@echoix any suggestions here? Upstream has no fix for it. It's not used. |
I'd need to have a deep look for this, as it might be impactful. I think we needed to revert one of my PRs that touched this if I remember well. I'd be cautious and read well. Was it @wenzeslaus that has experience with this file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrt to #1809
This PR updates the
__cmp__method insaferef.pyto be compatible with Python 3. Comparison methods__eq__and
__lt__are implemented to maintain the same functionality without requiring changes elsewhere in the code.Changes:
__eq__method for equality comparison.__lt__method for less-than comparison.__cmp__method now uses the rich comparison methods for its logic.This shouldn't change overall behavior of
saferefclass.