Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i.atcorr: major refactoring of create_iwave.py #3886

Merged
merged 8 commits into from
Nov 15, 2024
Merged

i.atcorr: major refactoring of create_iwave.py #3886

merged 8 commits into from
Nov 15, 2024

Conversation

pesekon2
Copy link
Contributor

  • speed up (e.g., do not run loops if one run is sufficient)
  • lower the amount of code duplicity
  • remove lines that actually do not do anything (e.g., lines containing declaration print without brackets)
  • general beauty salon treatment

@pesekon2
i.atcorr: major refactoring of create_iwave.py
6cfcc82 
* speed up (e.g., do not run loops if one run is sufficient)

* lower the amount of code duplicity

* remove lines that actually do not do anything (e.g., lines containing declaration print without brackets)

* general beauty salon treatment
@pesekon2 pesekon2 added Python Related code is in Python imagery labels Jun 18, 2024
@pesekon2 pesekon2 self-assigned this Jun 18, 2024
github-actions[bot]
github-actions bot reviewed Jun 18, 2024
View reviewed changes
imagery/i.atcorr/create_iwave.py Show resolved Hide resolved
imagery/i.atcorr/create_iwave.py Outdated Show resolved Hide resolved
imagery/i.atcorr/create_iwave.py Outdated Show resolved Hide resolved
echoix
echoix reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have time to finish reading all files, but here's a start

imagery/i.atcorr/create_iwave.py Show resolved Hide resolved
imagery/i.atcorr/create_iwave.py Show resolved Hide resolved
imagery/i.atcorr/create_iwave.py Outdated Show resolved Hide resolved
@echoix echoix mentioned this pull request Jul 7, 2024
Merged
@echoix echoix mentioned this pull request Sep 20, 2024
Closed
github-actions[bot]
github-actions bot reviewed Oct 26, 2024
View reviewed changes
imagery/i.atcorr/create_iwave.py Outdated Show resolved Hide resolved
imagery/i.atcorr/create_iwave.py Outdated Show resolved Hide resolved
pesekon2 and others added 3 commits October 26, 2024 15:39
@pesekon2 @github-actions
Update imagery/i.atcorr/create_iwave.py
6aef1bc 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pesekon2 @github-actions
Update imagery/i.atcorr/create_iwave.py
6192782 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pesekon2
Merge branch 'main' into i_atcorr_major_refactoring
afd0a6c
@pesekon2
Copy link
Contributor Author

@echoix ping for conversations.

@pesekon2
Copy link
Contributor Author

Thanks for the review!

@pesekon2 pesekon2 merged commit fe05858 into OSGeo:main Nov 15, 2024
26 checks passed
@pesekon2 pesekon2 deleted the i_atcorr_major_refactoring branch November 15, 2024 09:10
@github-actions github-actions bot added this to the 8.5.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@echoix echoix echoix approved these changes

Assignees

@pesekon2 pesekon2

Labels
imagery module Python Related code is in Python
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pesekon2 @echoix