Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new function Set-SetupCompleteInitialize #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

skyblaster
Copy link
Contributor

Move the core functionality of Set-SetupCompleteCreateStart to a new Set-SetupCompleteInitialize function for more consistency and modularization.

  • Responsible for ensuring that the SetupComplete folder, bat, and ps1 files are created
  • Add as a check to all Set-SetupComplete functions, so that they can create the files independently of the main task sequence.
  • This fixed some functions that would produce a 'scripts' file instead of a folder
  • Update all Set-SetupComplete functions to remove Write-Output "$PSFilePath - Not Found" else statements. If the intention is to append SetupComplete.ps1, we must make it so.

…Set-SetupCompleteInitialize function for more consistency and modularization
@gwblok
Copy link
Collaborator

gwblok commented Sep 30, 2024

This all looks good. Unsure when I'll get a chance to test this all, but initial glance, it all makes sense.
I'll try to get around to testing it soon.

I'm assuming you've already tested most of those features and confirmed it does make the setup complete files, and everything is working as expected?

@gwblok gwblok self-assigned this Sep 30, 2024
@skyblaster
Copy link
Contributor Author

I'm assuming you've already tested most of those features and confirmed it does make the setup complete files, and everything is working as expected?

Yes. Since they are easy to validate on a host system, I've tested them all.

I don't use many of these features, but I've tested one run through in a VM with no ill effects using the standard options in Start-OSDCloudGUI.

I see I missed adding the following files. But perhaps they are autogenerated?
Docs\Set-SetupCompleteInitialize.md
en-US\OSD-help.xml

@AkosBakos
Copy link
Collaborator

@OSDeploy any thoughts on the last question from @skyblaster regarding these files:
Docs\Set-SetupCompleteInitialize.md
en-US\OSD-help.xml

@gwblok
Copy link
Collaborator

gwblok commented Oct 1, 2024 via email

@OSDeploy
Copy link
Owner

Set-SetupCompleteInitialize.md
en-US\OSD-help.xml

Yes they are auto-generated. I'll address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants