Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
delcmo committed Dec 29, 2024
1 parent 9e548eb commit c0fd8d8
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 17 deletions.
37 changes: 21 additions & 16 deletions paper/paper.bib
Original file line number Diff line number Diff line change
Expand Up @@ -70,22 +70,6 @@ @article{Taylor-green-vortex
year = {1937}
}

# Double shear layer
@article{PhysRevE.87.013309,
title = {Entropically damped form of artificial compressibility for explicit simulation of incompressible flow},
author = {Clausen, Jonathan R.},
journal = {Phys. Rev. E},
volume = {87},
issue = {1},
pages = {013309},
numpages = {12},
year = {2013},
month = {Jan},
publisher = {American Physical Society},
doi = {10.1103/PhysRevE.87.013309},
url = {https://link.aps.org/doi/10.1103/PhysRevE.87.013309}
}

# Validation
# Natural convection
@article{Kuehn_Goldstein_1976, title={An experimental and theoretical study of natural convection in the annulus between horizontal concentric cylinders}, volume={74}, DOI={10.1017/S0022112076002012}, number={4}, journal={Journal of Fluid Mechanics}, author={Kuehn, T. H. and Goldstein, R. J.}, year={1976}, pages={695–719}} <div></div>
Expand All @@ -108,4 +92,25 @@ @article{10.1115/1.3240731
doi = {10.1115/1.3240731},
url = {https://doi.org/10.1115/1.3240731},
eprint = {https://asmedigitalcollection.asme.org/fluidsengineering/article-pdf/102/4/494/5531330/494\_1.pdf},
}

@article{SMOLENTSEV201565,
title = {An approach to verification and validation of MHD codes for fusion applications},
journal = {Fusion Engineering and Design},
volume = {100},
pages = {65-72},
year = {2015},
issn = {0920-3796},
doi = {https://doi.org/10.1016/j.fusengdes.2014.04.049},
url = {https://www.sciencedirect.com/science/article/pii/S0920379614003263},
author = {S. Smolentsev and S. Badia and R. Bhattacharyay and L. Bühler and L. Chen and Q. Huang and H.-G. Jin and D. Krasnov and D.-W. Lee and E. Mas {de les Valls} and C. Mistrangelo and R. Munipalli and M.-J. Ni and D. Pashkevich and A. Patel and G. Pulugundla and P. Satyamurthy and A. Snegirev and V. Sviridov and P. Swain and T. Zhou and O. Zikanov},
keywords = {Blanket, Liquid metal magnetohydrodynamics, Computer code},
abstract = {We propose a new activity on verification and validation (V&V) of MHD codes presently employed by the fusion community as a predictive capability tool for liquid metal cooling applications, such as liquid metal blankets. The important steps in the development of MHD codes starting from the 1970s are outlined first and then basic MHD codes, which are currently in use by designers of liquid breeder blankets, are reviewed. A benchmark database of five problems has been proposed to cover a wide range of MHD flows from laminar fully developed to turbulent flows, which are of interest for fusion applications: (A) 2D fully developed laminar steady MHD flow, (B) 3D laminar, steady developing MHD flow in a non-uniform magnetic field, (C) quasi-two-dimensional MHD turbulent flow, (D) 3D turbulent MHD flow, and (E) MHD flow with heat transfer (buoyant convection). Finally, we introduce important details of the proposed activities, such as basic V&V rules and schedule. The main goal of the present paper is to help in establishing an efficient V&V framework and to initiate benchmarking among interested parties. The comparison results computed by the codes against analytical solutions and trusted experimental and numerical data as well as code-to-code comparisons will be presented and analyzed in companion paper/papers.}
}

@misc{nasa-web,
title = {Turbulence Modeling Resource},
note = {Langley Research Center},
url = {https://turbmodels.larc.nasa.gov/},
year = {2024}
}
2 changes: 1 addition & 1 deletion paper/paper.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ As part of the VERTEX initiative, the primary mission of the VERTEX-CFD team is

# Current capabilities and development workflow

VERTEX-CFD solver is still under active development and currently implements the following capabilities: incompressible Navier-Stokes equations [@Clausen2013], temperature equation, induction-less and full-induction MHD models, RANS turbulence models and WALE (LES) [@nicoud:hal-00910373] turbulence model. Each new physics is implemented in closure models with unit tests. Physical models and coupling between equations were verified and validated against benchmark problems taken from the published literature: isothermal flows [@Taylor-green-vortex, @10.1115/1.3240731, @PhysRevE.87.013309], heated flows [@Kuehn_Goldstein_1976, @tritton_1959], transient and steady-state cases, turbulent cases, and MHD flows. VERTEX-CFD solver has demonstrated second-order temporal and spatial accuracy. Scaling of the VERTEX-CFD solver was assessed on CPUs and GPUs architecture. It was found that strong and weak scaling were comparable to other CFD solvers alike NekRS. (ADD FIGURE).
VERTEX-CFD solver is still under active development and currently implements the following capabilities: incompressible Navier-Stokes equations [@Clausen2013], temperature equation, induction-less and full-induction MHD models, RANS turbulence models and WALE (LES) [@nicoud:hal-00910373] turbulence model. Each new physics is implemented in closure models with unit tests. Physical models and coupling between equations were verified and validated against benchmark problems taken from the published literature: isothermal flows [@Taylor-green-vortex, @10.1115/1.3240731; @Clausen2013], heated flows [@Kuehn_Goldstein_1976; @tritton_1959], transient and steady-state cases, turbulent cases [@nicoud:hal-00910373; @nasa-web], and MHD flows [@SMOLENTSEV201565]. VERTEX-CFD solver has demonstrated second-order temporal and spatial accuracy. Scaling of the VERTEX-CFD solver was assessed on CPUs and GPUs architecture. It was found that strong and weak scaling were comparable to other CFD solvers alike NekRS. (ADD FIGURE).

The long term objectives of the VERTEX initiative is to facilitate the addition of new physical models by relying on a plug-and-play architecture, and also guarantee the correctness of the implemented model over time. New physics and equations are easily added to the global tree and allow for quick deployment of new physical model on HPC platforms. Such approach can only be made possible by setting clear requirements and review process for all developers contributing to the project code: any changes and additions to the source code is reviewed and tested before being merged. VERTEX-CFD solver is tested daily on a continuous integration (CI) workflow that is hosted on ORNL network.

Expand Down

0 comments on commit c0fd8d8

Please sign in to comment.