Use unordered_set for whitelist lookups #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All whitelist lookups are currently performed by a linear search over a
std::vector
ofstd::string
objects. Since peer IDs are always 20 bytes long, anstd::array
might be better suited for this, and has the added advantage of always storing the data contiguously, which is not a requirement withstd::string
s. Storing suchstd::array
s in anunordered_set
gives a clear performance advantage, as illustrated in this benchmark.Since whitelist lookups need to be made for every announce, I suppose this might have a very positive impact on the overall performance of the tracker.