Reduce code duplication in db.cpp, use builtin formatting in spdlog when logging, remove unnecessary usages of empty C-strings #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db.cpp
had some very repetitive code related to managing the query buffers. This is now handled by a local wrapper forstd::string
which provides the necessary functionality.Also, usages of
""
were replaced with equivalent functionality provided bystd::string
member functions where applicable, mostly in context of object construction (where it was completely removed, as the default constructor does the same thing) and checking if a string is empty.