Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for the RCMASTS keyword #4272

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Adds support for the RCMASTS keyword #4272

merged 3 commits into from
Jan 15, 2025

Conversation

hakonhagland
Copy link
Contributor

@hakonhagland hakonhagland commented Oct 21, 2024 •
edited
Loading

Adds support for the RCMASTS keyword in reservoir coupling.

@hakonhagland
Copy link
Contributor Author

jenkins build this opm-simulators=5620 please

@hakonhagland hakonhagland mentioned this pull request Oct 23, 2024
Merged
@hakonhagland
Copy link
Contributor Author

jenkins build this please

@hakonhagland
Copy link
Contributor Author

jenkins build this please

1 similar comment
@blattms
Copy link
Member

blattms commented Jan 13, 2025

jenkins build this please

blattms
blattms reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@blattms blattms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few nitpicks, though. Sorry.

opm/input/eclipse/Schedule/ResCoup/MasterMinimumTimeStep.cpp Outdated Show resolved Hide resolved
opm/input/eclipse/Schedule/ResCoup/MasterMinimumTimeStep.cpp Outdated Show resolved Hide resolved
opm/input/eclipse/Schedule/ResCoup/ReservoirCouplingInfo.hpp Outdated Show resolved Hide resolved
@hakonhagland
Copy link
Contributor Author

@blattms I have added two commits to address the comments

@hakonhagland
Copy link
Contributor Author

jenkins build this opm-simulators=5620 please

@blattms
Copy link
Member

blattms commented Jan 15, 2025 •
edited
Loading

Build with 25620 from opm-simulators (Although the test results are not found on jenkins...). Let's try with master...

@blattms
Copy link
Member

blattms commented Jan 15, 2025 •
edited
Loading

jenkins build this please

@blattms blattms merged commit 0ffd257 into OPM:master Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blattms blattms blattms left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hakonhagland @blattms