Fix sdcsrm 626 add google analytics #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igital/srm-rh-ui into fix-SDCSRM-626-add-google-analytics
ryangrundy7
reviewed
Aug 15, 2024
ryangrundy7
reviewed
Aug 15, 2024
AdamHawtin
requested changes
Aug 15, 2024
ryangrundy7
reviewed
Aug 19, 2024
ryangrundy7
reviewed
Aug 19, 2024
Co-authored-by: ryangrundy7 <[email protected]>
Co-authored-by: ryangrundy7 <[email protected]>
AdamHawtin
approved these changes
Aug 19, 2024
ryangrundy7
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
All the same as this PR: #52 but removing an old comment in the js code, and updating the used cookies table for GA based on their docs: https://support.google.com/analytics/answer/11397207?hl=en.
I've also made some small changes to the translations part of the README.
Has to be on another branch because the old one has been squashed and merged.
What has changed
How to test?
Links
https://jira.ons.gov.uk/browse/SDCSRM-626
Screenshots (if appropriate):