-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
704 type marker back data #143
Conversation
- Updating unit test data - intial fir flag now overwritten with bir ...
@robertswh this code now passes unit test data. It involved removing and the back data and re applying a couple of times. It might be possible to do this alternate ways, but this currently works for back data. |
@Jday7879 very nice. I think that's how I imagined it would work. I think this works as a bug fix and will require a more substantial refactor to simplify the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code all looks good, happy to approve changes
Pull Request Title
Summary
Add your summary here - keep it brief, to the point, and in plain English.
Type of Change
Checklists
This pull request meets the following requirements:
Creator Checklist
If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.
Reviewer Checklist
Additional Information
Please provide any additional information or context that would help the reviewer understand the changes in this pull request.
Related Issues
Link any related issues or pull requests here.