Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

464-OCEA-SRS-outputs #140

Merged
merged 9 commits into from
Jan 14, 2025
Merged

464-OCEA-SRS-outputs #140

merged 9 commits into from
Jan 14, 2025

Conversation

NathanKelly-ONS
Copy link
Collaborator

Pull Request Title

Summary

This pull requests implements the functionality required for creating the OCEA/SRS outputs. I still need to figure out how to add additional outputs to the config (hence why this is a draft pull request).

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Checklists

This pull request meets the following requirements:

Creator Checklist

  • Installable with all dependencies recorded
  • Runs without error
  • Follows PEP8 and project-specific conventions
  • Appropriate use of comments, for example, no descriptive comments
  • Functions documented using Numpy style docstrings
  • [N/A] Assumptions and decisions log considered and updated if appropriate
  • Unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • Other forms of testing such as end-to-end and user-interface testing have been considered and updated as required

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

Reviewer Checklist

  • Test suite passes (locally as a minimum)
  • Peer reviewed with review recorded

Additional Information

Please provide any additional information or context that would help the reviewer understand the changes in this pull request.

Related Issues

Link any related issues or pull requests here.

@NathanKelly-ONS
Copy link
Collaborator Author

@lhubbardONS when you get a minute, could you take a look to make sure I've used produce_additional_outputs correctly and made the changes in the correct places please?

@lhubbardONS
Copy link
Collaborator

@lhubbardONS when you get a minute, could you take a look to make sure I've used produce_additional_outputs correctly and made the changes in the correct places please?

All looks good to me!

@NathanKelly-ONS NathanKelly-ONS marked this pull request as ready for review January 13, 2025 15:11
@AntonZogk AntonZogk self-requested a review January 13, 2025 15:15
MBS output formatted according to SRS/OCEA requirements
"""

output_df = df[
Copy link
Collaborator

@AntonZogk AntonZogk Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined arg df at line 18 should be additional_outputs_df

Copy link
Collaborator

@AntonZogk AntonZogk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs 3 actions:

  1. Rename object name df
  2. Run pre commit hooks
  3. Fix unit test for replace_l_values (it looked like it needs sorting prior to asserting)

@AntonZogk AntonZogk merged commit 9f2a68e into main Jan 14, 2025
8 checks passed
@AntonZogk AntonZogk deleted the 464-ocea-srs-outputs branch January 14, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants