-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
464-OCEA-SRS-outputs #140
464-OCEA-SRS-outputs #140
Conversation
…monthly-business-survey-results into 464-ocea-srs-outputs
@lhubbardONS when you get a minute, could you take a look to make sure I've used produce_additional_outputs correctly and made the changes in the correct places please? |
All looks good to me! |
MBS output formatted according to SRS/OCEA requirements | ||
""" | ||
|
||
output_df = df[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undefined arg df
at line 18 should be additional_outputs_df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs 3 actions:
- Rename object name df
- Run pre commit hooks
- Fix unit test for replace_l_values (it looked like it needs sorting prior to asserting)
Pull Request Title
Summary
This pull requests implements the functionality required for creating the OCEA/SRS outputs. I still need to figure out how to add additional outputs to the config (hence why this is a draft pull request).
Type of Change
Checklists
This pull request meets the following requirements:
Creator Checklist
If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.
Reviewer Checklist
Additional Information
Please provide any additional information or context that would help the reviewer understand the changes in this pull request.
Related Issues
Link any related issues or pull requests here.