-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
692 create population counts #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I've made a couple of suggestion for comments and I think the sampled
column name needs changing to is_sampled
to be consistent with all the changes I committed to this branch yesterday. Happy to merge once you've checked those suggestions.
) | ||
|
||
df_sampled = calculate_turnover_sum_count( | ||
df.loc[df["sampled"]], period, strata, colname="sample", **config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to "is_sampled" everywhere else, so I think it needs changing here
Co-authored-by: Wil Roberts <[email protected]>
Co-authored-by: Wil Roberts <[email protected]>
Co-authored-by: Wil Roberts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
Pull Request Title
Creating population counts function
Summary
function to create the population count output for MBS
This can be output as dataframe or saved to output_path as an optional extra
Type of Change
Checklists
This pull request meets the following requirements:
Creator Checklist
If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.
Reviewer Checklist
Additional Information
Please provide any additional information or context that would help the reviewer understand the changes in this pull request.
Related Issues
Link any related issues or pull requests here.