Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

683 filter out questions in staging #133

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

AntonZogk
Copy link
Collaborator

@AntonZogk AntonZogk commented Dec 3, 2024

683 filter out questions in staging

Summary

Add functionality to staging to remove question codes from pipeline processing (impute, estimation, outlier detection)
The removed questions are stored as csv.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Checklists

This pull request meets the following requirements:

Creator Checklist

  • Installable with all dependencies recorded
  • Runs without error
  • Follows PEP8 and project-specific conventions
  • Appropriate use of comments, for example, no descriptive comments
  • Functions documented using Numpy style docstrings
  • Assumptions and decisions log considered and updated if appropriate
  • Unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • Other forms of testing such as end-to-end and user-interface testing have been considered and updated as required

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

Reviewer Checklist

  • Test suite passes (locally as a minimum)
  • Peer reviewed with review recorded

Additional Information

Don't think required, comment in PR for any additional info

Related Issues

Jira ticket 683


"calibration_group" : "calibration_group"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was highlighted from the hooks, not related to this task, calibration_group is defined twice in the config.json so removed the second to pass hooks

Copy link
Collaborator

@robertswh robertswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Nice work on the mocking.

@AntonZogk AntonZogk merged commit ff6dcf3 into main Dec 4, 2024
5 checks passed
@AntonZogk AntonZogk deleted the 683-filter-out-questions-in-staging branch December 4, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants