Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

649 review pre commit hooks #130

Merged
merged 4 commits into from
Nov 28, 2024
Merged

649 review pre commit hooks #130

merged 4 commits into from
Nov 28, 2024

Conversation

Jday7879
Copy link
Collaborator

@Jday7879 Jday7879 commented Nov 25, 2024

Pull Request Title

649 review pre commit hooks

Summary

changes to pre commit to now use github URLs instead of local package install
Adding bandit commit hook
Removed local python files for large files, now pulling from git repos

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):
    Updating pre-commit hooks

Checklists

This pull request meets the following requirements:

Creator Checklist

  • Installable with all dependencies recorded
  • Runs without error
  • Follows PEP8 and project-specific conventions
  • Appropriate use of comments, for example, no descriptive comments
  • Functions documented using Numpy style docstrings
  • Assumptions and decisions log considered and updated if appropriate
  • Unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • Other forms of testing such as end-to-end and user-interface testing have been considered and updated as required

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

Reviewer Checklist

  • Test suite passes (locally as a minimum)
  • Peer reviewed with review recorded

Additional Information

Please provide any additional information or context that would help the reviewer understand the changes in this pull request.

Related Issues

Link any related issues or pull requests here.

@Jday7879 Jday7879 marked this pull request as ready for review November 27, 2024 12:49
@Jday7879 Jday7879 requested a review from AntonZogk November 28, 2024 10:49
Copy link
Collaborator

@AntonZogk AntonZogk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking great, thanks @Jday7879 for this.

For reference i will share this pre-commit/pre-commit#1151 which has more details of what we discussed when installing hooks and running them for the first time.

@Jday7879 Jday7879 merged commit 7464580 into main Nov 28, 2024
5 checks passed
@Jday7879 Jday7879 deleted the 649-review-pre-commit-hooks branch November 28, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants