Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new combined imputation and derived flag column #128

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

ldavies99
Copy link
Collaborator

Summary

Add line at the end of the impute wrapper function to create a new combined imputation and derived flag column.

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

@ldavies99 ldavies99 self-assigned this Nov 21, 2024
Copy link
Collaborator

@Jday7879 Jday7879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice solution!
Is it a potential issue that if our imputation logic fails and we fail to impute, this would also be marked as a "d". Might be worth to specify "d" based on the "derived" column, and add a new letter to fill the final nans?

Happy to approve if this is something you have already checked :)

@ldavies99 ldavies99 requested a review from Jday7879 November 26, 2024 16:37
Copy link
Collaborator

@Jday7879 Jday7879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Luke! I didnt even clock that constrained questions would also have the d marker placed on them. this should solve that in cases when one has been imputed :)
(I'll sort the hooks now )

@ldavies99 ldavies99 merged commit 7de018c into main Nov 27, 2024
5 checks passed
@ldavies99 ldavies99 deleted the 601-combine-imputation-and-derived-flag branch November 27, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants