Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schemas to use strong tags #495

Merged
merged 7 commits into from
Apr 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: PR

on:
on:
pull_request:
branches:
- main
Expand All @@ -9,7 +9,7 @@ jobs:
lint:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- run: |
echo "PYTHON_VERSION=$(cat .python-version)" >> $GITHUB_ENV
- uses: actions/setup-python@v4
Expand Down Expand Up @@ -37,7 +37,7 @@ jobs:
validate-schemas:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- run: |
echo "PYTHON_VERSION=$(cat .python-version)" >> $GITHUB_ENV
- uses: actions/setup-python@v4
Expand All @@ -60,15 +60,15 @@ jobs:
- name: Install virtual environment
if: steps.cache-virtualenv.outputs.cache-hit != 'true'
run: poetry install
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Spin up validator
run: make run-validator
- name: Validate schemas
run: make validate-schemas
test-translation-templates:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- run: |
echo "PYTHON_VERSION=$(cat .python-version)" >> $GITHUB_ENV
- uses: actions/setup-python@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
add-schemas-to-release:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
Yuyuutsu marked this conversation as resolved.
Show resolved Hide resolved
- name: Zip artifacts
run: zip -r schemas.zip schemas
- name: Release
Expand Down
70 changes: 35 additions & 35 deletions schemas/business/en/1_0005.json

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions schemas/business/en/1_0102.json
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@
"question": {
"id": "question6658f716-7f5f-4488-ab20-2af1dc694294",
"title": {
"text": "For the period {from} to {to}, what was the value of {ru_name}&#39;s <em>total retail turnover</em>?",
"text": "For the period {from} to {to}, what was the value of {ru_name}&#39;s <strong>total retail turnover</strong>?",
"placeholders": [
{
"placeholder": "from",
Expand Down Expand Up @@ -469,7 +469,7 @@
"question": {
"id": "questionconfirmation-page-for-6658f716-7f5f-4488-ab20-2af1dc694294",
"title": {
"text": "For the period {from} to {to}, the value of the total retail turnover was <em>{total_retail_turnover}</em>, is this correct?",
"text": "For the period {from} to {to}, the value of the total retail turnover was <strong>{total_retail_turnover}</strong>, is this correct?",
"placeholders": [
{
"placeholder": "from",
Expand Down Expand Up @@ -611,7 +611,7 @@
"question": {
"id": "questione1ddd2ff-78ee-4476-8b9d-ea7a2b9d7c9b",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <em>internet</em> sales?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <strong>internet</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down
8 changes: 4 additions & 4 deletions schemas/business/en/1_0112.json
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@
"question": {
"id": "question6658f716-7f5f-4488-ab20-2af1dc694294",
"title": {
"text": "For the period {ref_p_start_date} to {ref_p_end_date}, what was the value of {ru_name}&#39;s <em>total retail turnover</em>?",
"text": "For the period {ref_p_start_date} to {ref_p_end_date}, what was the value of {ru_name}&#39;s <strong>total retail turnover</strong>?",
"placeholders": [
{
"placeholder": "ref_p_start_date",
Expand Down Expand Up @@ -494,7 +494,7 @@
"question": {
"id": "questionconfirmation-page-for-6658f716-7f5f-4488-ab20-2af1dc694294",
"title": {
"text": "For the period {ref_p_start_date} to {ref_p_end_date}, the value of the total retail turnover was <em>&#xA3;0</em>, is this correct?",
"text": "For the period {ref_p_start_date} to {ref_p_end_date}, the value of the total retail turnover was <strong>&#xA3;0</strong>, is this correct?",
"placeholders": [
{
"placeholder": "ref_p_start_date",
Expand Down Expand Up @@ -594,7 +594,7 @@
"question": {
"id": "questione1ddd2ff-78ee-4476-8b9d-ea7a2b9d7c9b",
"title": {
"text": "Of the <em>{total_retail_turnover}</em>, what was the value of <em>internet</em> sales?",
"text": "Of the <strong>{total_retail_turnover}</strong>, what was the value of <strong>internet</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -988,7 +988,7 @@
"question": {
"id": "questionconfirmation-page-for-1afaffa9-0ed7-4e1a-8fd4-6ea4d11fb153",
"title": {
"text": "On {employment_date}, the number of employees for {ru_name} was <em>0</em>, is this correct?",
"text": "On {employment_date}, the number of employees for {ru_name} was <strong>0</strong>, is this correct?",
"placeholders": [
{
"placeholder": "employment_date",
Expand Down
18 changes: 9 additions & 9 deletions schemas/business/en/1_0203.json
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@
"question": {
"id": "question6658f716-7f5f-4488-ab20-2af1dc694294",
"title": {
"text": "For the period {from} to {to}, what was the value of {ru_name}&#39;s <em>total retail turnover</em>?",
"text": "For the period {from} to {to}, what was the value of {ru_name}&#39;s <strong>total retail turnover</strong>?",
"placeholders": [
{
"placeholder": "from",
Expand Down Expand Up @@ -589,7 +589,7 @@
"question": {
"id": "questionconfirmation-page-for-6658f716-7f5f-4488-ab20-2af1dc694294",
"title": {
"text": "For the period {from} to {to}, the value of the total retail turnover was <em>{total_retail_turnover}</em>, is this correct?",
"text": "For the period {from} to {to}, the value of the total retail turnover was <strong>{total_retail_turnover}</strong>, is this correct?",
"placeholders": [
{
"placeholder": "from",
Expand Down Expand Up @@ -731,7 +731,7 @@
"question": {
"id": "questione1ddd2ff-78ee-4476-8b9d-ea7a2b9d7c9b",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <em>food</em> sales?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <strong>food</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -802,7 +802,7 @@
"question": {
"id": "questionc6fdf75d-b478-45b0-8a1f-e581632a63b6",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <em>alcohol, confectionery and tobacco</em> sales?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <strong>alcohol, confectionery and tobacco</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -865,7 +865,7 @@
"question": {
"id": "question6f9e84d5-b373-4b9c-a694-5ef95a8ef191",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <em>clothing and footwear</em> sales?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <strong>clothing and footwear</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -930,7 +930,7 @@
"question": {
"id": "question8290215a-cfba-4d7a-8777-2cdcb5e3db95",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of sales for <em>household goods</em>?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of sales for <strong>household goods</strong>?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -1007,7 +1007,7 @@
"question": {
"id": "question63a9c2f1-0ecb-4891-a8b5-f0c8b6622ecb",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <em>other</em> sales?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <strong>other</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -1095,7 +1095,7 @@
"question": {
"id": "questionea1ecf32-36e7-4445-ba63-2aa2f9531410",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <em>internet</em> sales?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <strong>internet</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -1158,7 +1158,7 @@
"id": "question94192f6c-a726-457f-a6c4-13da42940b05",
"title": "Please explain any changes in your figures from previous returns, if applicable",
"description": [
"<p>If you provide comments we are less likely to contact you with data queries.</p><p>You have nearly finished! <em>Make sure you continue to the next page and select &#39;submit answers&#39; at the bottom.</em></p>"
"<p>If you provide comments we are less likely to contact you with data queries.</p><p>You have nearly finished! <strong>Make sure you continue to the next page and select &#39;submit answers&#39; at the bottom.</strong></p>"
],
"type": "General",
"answers": [
Expand Down
20 changes: 10 additions & 10 deletions schemas/business/en/1_0205.json
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@
"question": {
"id": "question6658f716-7f5f-4488-ab20-2af1dc694294",
"title": {
"text": "For the period {from} to {to}, what was the value of {ru_name}&#39;s <em>total retail turnover</em>?",
"text": "For the period {from} to {to}, what was the value of {ru_name}&#39;s <strong>total retail turnover</strong>?",
"placeholders": [
{
"placeholder": "from",
Expand Down Expand Up @@ -611,7 +611,7 @@
"question": {
"id": "questionconfirmation-page-for-6658f716-7f5f-4488-ab20-2af1dc694294",
"title": {
"text": "For the period {from} to {to}, the value of the total retail turnover was <em>{total_retail_turnover}</em>, is this correct?",
"text": "For the period {from} to {to}, the value of the total retail turnover was <strong>{total_retail_turnover}</strong>, is this correct?",
"placeholders": [
{
"placeholder": "from",
Expand Down Expand Up @@ -753,7 +753,7 @@
"question": {
"id": "questione1ddd2ff-78ee-4476-8b9d-ea7a2b9d7c9b",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <em>food</em> sales?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <strong>food</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -824,7 +824,7 @@
"question": {
"id": "questionc6fdf75d-b478-45b0-8a1f-e581632a63b6",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <em>alcohol, confectionery and tobacco</em> sales?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <strong>alcohol, confectionery and tobacco</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -887,7 +887,7 @@
"question": {
"id": "question6f9e84d5-b373-4b9c-a694-5ef95a8ef191",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <em>clothing and footwear</em> sales?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <strong>clothing and footwear</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -952,7 +952,7 @@
"question": {
"id": "question8290215a-cfba-4d7a-8777-2cdcb5e3db95",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of sales for <em>household goods</em>?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of sales for <strong>household goods</strong>?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -1029,7 +1029,7 @@
"question": {
"id": "question63a9c2f1-0ecb-4891-a8b5-f0c8b6622ecb",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <em>other</em> sales?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <strong>other</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -1117,7 +1117,7 @@
"question": {
"id": "questionea1ecf32-36e7-4445-ba63-2aa2f9531410",
"title": {
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <em>internet</em> sales?",
"text": "Of the {total_retail_turnover} total retail turnover, what was the value of <strong>internet</strong> sales?",
"placeholders": [
{
"placeholder": "total_retail_turnover",
Expand Down Expand Up @@ -1178,7 +1178,7 @@
"type": "Question",
"question": {
"id": "questionc3572158-9874-45e1-9628-351a6cea2cfc",
"title": "What was the total sale of <em>automotive fuel</em>?",
"title": "What was the total sale of <strong>automotive fuel</strong>?",
"guidance": {
"contents": [
{
Expand Down Expand Up @@ -1223,7 +1223,7 @@
"id": "question9897812e-5097-4359-bc96-86ff55b50267",
"title": "Please explain any changes in your figures from previous returns, if applicable",
"description": [
"<p>If you provide comments we are less likely to contact you with data queries.</p><p>You have nearly finished! <em>Make sure you continue to the next page and select &#39;submit answers&#39; at the bottom.</em></p>"
"<p>If you provide comments we are less likely to contact you with data queries.</p><p>You have nearly finished! <strong>Make sure you continue to the next page and select &#39;submit answers&#39; at the bottom.</strong></p>"
],
"type": "General",
"answers": [
Expand Down
Loading
Loading