Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAR 2324 Update roofing tiles #458

Merged
merged 7 commits into from
Dec 11, 2023
Merged

EAR 2324 Update roofing tiles #458

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
34cbf34
Update roofing tiles
farres1 Dec 11, 2023
88b2f8b
Remove unused answer codes
farres1 Dec 11, 2023
d31bba9
Fix array error
kayloshai Dec 11, 2023
6ca663e
Add answer prefix
farres1 Dec 11, 2023
13cbad1
Merge branch 'EAR-2324-roofing-tiles' of github.com:ONSdigital/eq-que…
farres1 Dec 11, 2023
575e31d
Add answer IDs to answer codes
farres1 Dec 11, 2023
dd32d8a
Add space
farres1 Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 26 additions & 22 deletions schemas/business/en/qrt_0001.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@
"answer_id": "answer3aa044a8-26dd-403f-8646-8a9c8874b3be",
"code": "9991"
},
{
"answer_id": "answerbf11b2d4-3f36-4466-8e59-4f8bc3cce4c8",
"code": "147"
},
{
"answer_id": "add-another-additional-new-sites",
"code": "9990"
},
{
"answer_id": "answerbf11b2d4-3f36-4466-8e59-4f8bc3cce4c8",
"code": "147"
},
{
"answer_id": "answer27f27859-fc11-4577-b9bb-745407356498",
"code": "9989"
Expand Down Expand Up @@ -259,7 +259,7 @@
"question": "Local unit list",
"contents": [
{
"description": "In this section you will be presented with your business's local units that this return covers. You will be asked to check the list for any errors and provide details of any changes."
"description": "In this section you will be presented with your business's local units that this return covers. You will be asked to check the list for any errors and provide details of any changes. If a unit is no longer covered by this return, include the date that it ceased production."
}
]
},
Expand Down Expand Up @@ -328,7 +328,7 @@
"description": "You will be asked to provide the details of production for concrete roofing tiles."
},
{
"description": "<strong>This section includes:</strong>"
"description": "<strong>This includes:</strong>"
},
{
"list": [
Expand All @@ -345,10 +345,10 @@
}
},
{
"id": "roofing-tiles-manufactured",
"id": "concrete-roofing-tiles-manufactured",
"type": "Question",
"question": {
"id": "questionroofing-tiles-manufactured",
"id": "questionconcrete-roofing-tiles-manufactured",
"title": {
"text": "For the period {ref_p_start_date} to {ref_p_end_date}, how many square metres of concrete roofing tiles were manufactured by {ru_name}?",
"placeholders": [
Expand Down Expand Up @@ -418,7 +418,7 @@
}
]
},
"page_title": "Roofing tiles manufactured"
"page_title": "Concrete roofing tiles manufactured"
},
{
"id": "concrete-roofing-tiles-delivered",
Expand Down Expand Up @@ -542,7 +542,7 @@
"title": "Local unit list",
"contents": [
{
"description": "In this section you will presented with your business&#39;s local units that this return covers. You will be asked to check this list for any errors and provide details of any changes."
"description": "In this section you will presented with your business&#39;s local units that this return covers. You will be asked to check this list for any errors and provide details of any changes. If a unit is no longer covered by this return, include the date that it ceased production."
}
]
}
Expand All @@ -560,7 +560,7 @@
},
{
"list": [
"if the unit is no longer appropriate, with the date that it ceased production"
"if the unit is no longer covered by this return, with the date that it ceased production"
]
},
{
Expand Down Expand Up @@ -599,19 +599,17 @@
"placeholder": "localunits_address",
"transforms": [
{
"transform": "concatenate_list",
"arguments": {
"delimiter": ", ",
"list_to_concatenate": [
{
"source": "supplementary_data",
"identifier": "local-units",
"selectors": [
"address"
]
"selectors": ["address"]
}
]
},
"transform": "concatenate_list"
],
"delimiter": ","
MebinAbraham marked this conversation as resolved.
Show resolved Hide resolved
}
}
]
}
Expand Down Expand Up @@ -839,7 +837,7 @@
"question": {
"id": "questionnature-of-work-carried-on-at-the-new-unit",
"title": {
"text": "What is the nature of work carried on at the new unit <em>{name_of_new_unit}</em> <em>{address_and_postcode_of_new_unit}</em>?",
"text": "What is the nature of work carried on at the new unit <em>{name_of_new_unit}</em>, <em>{address_and_postcode_of_new_unit}</em>?",
"placeholders": [
{
"placeholder": "name_of_new_unit",
Expand Down Expand Up @@ -875,7 +873,7 @@
"question": {
"id": "questionnumber-of-persons-employed-at-the-new-unit",
"title": {
"text": "What is the number of persons employed at the new unit <em>{name_of_new_unit}</em> <em>{address_and_postcode_of_new_unit}</em>?",
"text": "What is the number of persons employed at the new unit {name_of_new_unit}, {address_and_postcode_of_new_unit}?",
"placeholders": [
{
"placeholder": "name_of_new_unit",
Expand Down Expand Up @@ -912,7 +910,7 @@
"question": {
"id": "questiondate-new-unit-came-into-production",
"title": {
"text": "What date did the new unit <em>{name_of_new_unit}</em> <em>{address_and_postcode_of_new_unit}</em> come into production?",
"text": "What date did the new unit {name_of_new_unit}, {address_and_postcode_of_new_unit} come into production?",
"placeholders": [
{
"placeholder": "name_of_new_unit",
Expand Down Expand Up @@ -1059,7 +1057,13 @@
"guidance": {
"contents": [
{
"description": "Include<strong> </strong>comments on figures included in this return, for example, to explain any substantial fluctuations in your figures compared with those of the previous return."
"description": "<strong>Include:</strong>"
},
{
"list": [
"comments on figures included in this return, for example, to explain any substantial fluctuations in your figures compared with those of the previous return",
"any additional information about your business&#39;s local units"
]
}
]
},
Expand Down