Update the menu CSS to ensure the columns are consistent width, and update the macro to ensure both text and link are present before outputting a link #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix cookiebanner settings link URL variable name (CMS-265) * Make the contact details name + email unique (CMS-225) * Add test for the unique constraint * Update contact details listings to include email/phone * Bump deps. Mainly Django 5.1.4
--------- Co-authored-by: Mebin Abraham <[email protected]> Co-authored-by: kacperpONS <[email protected]> Co-authored-by: Dan Braghiș <[email protected]> Co-authored-by: Jake Howard <[email protected]> Co-authored-by: Helen Chapman <[email protected]> Co-authored-by: Mebin Abraham <[email protected]>
* Add a custom chooser for release calendar pages that only includes upcoming release calendar pages * Add missing string translation on the information page template * Drop page status column * Ensure the bundle page chooser deduplicates choices
…pdate the macro to ensure both text and link are present before outputting a link
zerolab
reviewed
Jan 6, 2025
zerolab
reviewed
Jan 7, 2025
| </a> | ||
| {% endif %} | ||
| <a href="{{ item.url }}" class="navigation__link"> | ||
| <h2 class="ons-u-fs-s--b ons-u-mb-no navigation__heading avigation__heading--key-link">{{ item.text }}</h2> |
There was a problem hiding this comment.
question: should the nesting be inverted? that is: <h2><a></a></h2> rather than <a><h2>></h2></a> or is this how the DS does it?
There was a problem hiding this comment.
Good spot. In terms of HTML(5) validation, it doesn't matter. I can't see an example of a header and link together in the current base template in the design system, but both gov.uk and w3c use links inside headings, so I'll switch it.
There was a problem hiding this comment.
Co-authored-by: Dan Braghiș <[email protected]>
* Exclude any release calendar page with a past date from the bundle RC chooser * Update dependencies Mainly Wagtail 6.2.3 Also includes https://pillow.readthedocs.io/en/stable/releasenotes/11.1.0.html which should speed up PNG saving
* Styling for the release page plus some refactoring * Spacing tweaks * Duplicate accreditation logo to avoid sharing classes with the header * Pass through classes to census and accreditation logos to be DRY * Fix to spacing class * Adjust layout of census and accreditation logos, and ensure census logo is visible in high-contrast mode * Add a new include for contact details, and ensure spacing of release content is correct * Make the contact details component variable more generic --------- Co-authored-by: Dan Braghiș <[email protected]>
…nt-issues-CMS-169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
How to review
Follow-up Actions
List any follow-up actions (if applicable), like needed documentation updates or additional testing.