Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Use utility classes to replace individual margin and padding lines in css #222

Open
MagdalenaLarge opened this issue Sep 30, 2024 · 0 comments
Labels
Blocked Medium Priority Tech improvements Tech debt, cleanup, code standardisation etc.

Comments

@MagdalenaLarge
Copy link

MagdalenaLarge commented Sep 30, 2024

Description

Blocked by: #223

We aim to replace every individual margin and padding declaration css by extending our utility classes. This will allow us to reuse code and have a single point of update if these sizes need to change in the future.

Task
Identify where we could reuse the utility classes for margins and padding and replace the lines with extending the utility classes like this example below. The sizes can be found in _margin.scss and _padding.scss. Because the utility classes use !important as default, use the new functionality to remove this where this causes issues by overriding styles we may not want to.

Example
Before:
Screenshot 2024-10-25 at 13 43 37
After:
Screenshot 2024-10-25 at 13 45 05

@MagdalenaLarge MagdalenaLarge added the Refine To be refined label Sep 30, 2024
@rmccar rmccar changed the title [TASK] Changes to the utility classes on margins and padding [TASK] Update margins and padding utility classes to give option to remove !important Oct 25, 2024
@rmccar rmccar changed the title [TASK] Update margins and padding utility classes to give option to remove !important [TASK] Use utility classes to replace individual margin and padding lines in css Oct 25, 2024
@rmccar rmccar added Tech improvements Tech debt, cleanup, code standardisation etc. Blocked labels Oct 25, 2024
@MagdalenaLarge MagdalenaLarge removed the Refine To be refined label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Medium Priority Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

No branches or pull requests

3 participants