Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to include links in description list #3464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Dec 23, 2024

What is the context of this PR?

This PR fixes - https://jira.ons.gov.uk/browse/ONSDESYS-248.

This adds an option to include links to description lists.

How to review this PR

Review that all macro and visual test pass
Check that the changes matches the requirement and the link behaves as it should on hover and focus mode

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Enhancement Change of existing feature label Dec 23, 2024
@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team December 23, 2024 14:59
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit ef74f59
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/67697ae3b874540008555f8c
😎 Deploy Preview https://deploy-preview-3464--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant