Added a new Variant in Header Component #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
requested changes
Dec 16, 2024
rmccar
reviewed
Dec 16, 2024
...e/ds-vr-test__components_header_example-header-with-navigation-only_0_document_0_desktop.png
Outdated
Show resolved
Hide resolved
rmccar
reviewed
Dec 16, 2024
rmccar
reviewed
Dec 16, 2024
Co-authored-by: Precious Onyenaucheya <[email protected]>
…om/ONSdigital/design-system into enhancement/208/new-header-variant
rmccar
reviewed
Dec 17, 2024
Co-authored-by: rmccar <[email protected]>
precious-onyenaucheya-ons
approved these changes
Dec 17, 2024
rmccar
previously approved these changes
Dec 17, 2024
rmccar
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-208
Added a new variant in the header as per figma and prototype
How to review this PR
Check the new example created matches the design in figma and prototype
Checklist
This needs to be completed by the person raising the PR.