-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline description list variant #3439
Add inline description list variant #3439
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think the use of dt and dd tags are breaking the style from the prototype. At the moment this is forcing the text to wrap in a way different to the prototype. Look at the 'Business' column in this example. This is the example in the prototype. You can see from the code that they are using a span tag for the 'Business' column and then just test for information about the release - so the text will wrap underneath 'Business' |
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
What is the context of this PR?
ONSDESYS-189....
Created new Description list variant as per the Figma.
Prototype link
How to review this PR
Check that new example-inline-description-list in Description List component matches the figma design
Checklist
This needs to be completed by the person raising the PR.