Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Line-height in tab component #3432

Merged
merged 8 commits into from
Nov 28, 2024
Merged

Remove Line-height in tab component #3432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
66da5bc
chnages in .ons-tab--row
SriHV Nov 20, 2024
04ed402
Merge branch 'main' into enhancement/3393/adjust-line-height-on-detai…
SriHV Nov 20, 2024
3be97b4
adding visual test changes
SriHV Nov 20, 2024
4a84b7d
Merge branch 'main' into enhancement/3393/adjust-line-height-on-detai…
SriHV Nov 20, 2024
b7ed679
Merge branch 'main' into enhancement/3393/adjust-line-height-on-detai…
SriHV Nov 22, 2024
a1806b0
Merge branch 'main' into enhancement/3393/adjust-line-height-on-detai…
SriHV Nov 26, 2024
e7c3651
Update src/components/tabs/_tabs.scss
SriHV Nov 26, 2024
97e7628
changes in visual tests
SriHV Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rence/ds-vr-test__components_tabs_example-tabs-details_0_document_0_desktop.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...erence/ds-vr-test__components_tabs_example-tabs-details_0_document_1_tablet.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...aps_reference/ds-vr-test__components_tabs_example-tabs_0_document_0_desktop.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...maps_reference/ds-vr-test__components_tabs_example-tabs_0_document_1_tablet.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 10 additions & 11 deletions src/components/tabs/_tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,10 @@
border-radius: 3px 3px 0 0;
color: var(--ons-color-text);
display: inline-block;
height: 2.55rem;
line-height: 2.25rem;
height: 2.5rem;
margin: 0 0.5rem 0 0;
overflow: visible;
padding: 0 1rem;
padding: 0.25rem 1rem 0.25rem;
position: relative;
text-decoration: underline;

Expand All @@ -62,10 +61,10 @@
background-color: var(--ons-color-focus);
border-bottom: 1px solid var(--ons-color-borders);
box-shadow:
inset 0 0 0 9px var(--ons-color-button-secondary),
inset 17px 0 0 0 var(--ons-color-button-secondary),
inset -17px 0 0 0 var(--ons-color-button-secondary),
inset 0 -13px 0 0 var(--ons-color-text-link-focus);
inset 0 0 0 5px var(--ons-color-button-secondary),
inset 15px 0 0 0 var(--ons-color-button-secondary),
inset -14px 0 0 0 var(--ons-color-button-secondary),
inset 0 -9px 0 0 var(--ons-color-text-link-focus);
color: var(--ons-color-text-link-focus);

// Add transparent outline because Windows High Contrast Mode doesn't show box-shadows
Expand All @@ -88,10 +87,10 @@
&:focus {
background-color: var(--ons-color-focus);
box-shadow:
inset 0 0 0 9px var(--ons-color-page-light),
inset 17px 0 0 0 var(--ons-color-page-light),
inset -17px 0 0 0 var(--ons-color-page-light),
inset 0 -13px 0 0 var(--ons-color-text-link-focus);
inset 0 0 0 5px var(--ons-color-page-light),
inset 15px 0 0 0 var(--ons-color-page-light),
inset -14px 0 0 0 var(--ons-color-page-light),
inset 0 -9px 0 0 var(--ons-color-text-link-focus);
text-decoration: none;
}
}
Expand Down