Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lighthouse interstitial page test #3407

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Oct 25, 2024

What is the context of this PR?

Fixes: ONSdigital/design-team#218

The headings in the example were not sequential because the details component was being set to heading level 4 when there was only a h1 above it. Removing this was causing the text to go much bigger than we wanted because it was inside a div with the ons-page__body class. I have also updated that class to not change the size of details component text to stop this.

How to review this PR

  • Check the lighthouse tests in the github actions and see that the result for the test for the example-survey-interstitial-page example is now 100
  • Also run the test locally on this branch in chrome and on the main branch to see that this issue is now fixed

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar self-assigned this Oct 25, 2024
@rmccar rmccar added the Accessibility Issues discovered through accessibility testing label Oct 25, 2024
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit e21be3e
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/6721489a22e23b000857901a
😎 Deploy Preview https://deploy-preview-3407--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar requested a review from a team October 25, 2024 10:12
@rmccar rmccar merged commit adc76ba into main Oct 29, 2024
38 checks passed
@rmccar rmccar deleted the fix-lighthouse-interstitial-page-test branch October 29, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues discovered through accessibility testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Fix Lighthouse failure - Interstitial page
2 participants