Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lighthouse highlight test #3406

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Fix lighthouse highlight test #3406

merged 3 commits into from
Oct 29, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Oct 24, 2024

What is the context of this PR?

Fixes: ONSdigital/design-team#217

This updates the highlighting example so that the headings are sequential by changing the second h1 to a h2

How to review this PR

  • Check the lighthouse tests in the github actions and see that the result for the test for the example-highlighting example is now 100
  • Also run the test locally on this branch in chrome and on the main branch to see that this issue is now fixed.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar added the Accessibility Issues discovered through accessibility testing label Oct 24, 2024
@rmccar rmccar self-assigned this Oct 24, 2024
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit d06caa3
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/6720e5eca469b60008832a9a
😎 Deploy Preview https://deploy-preview-3406--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar merged commit 9db878b into main Oct 29, 2024
39 checks passed
@rmccar rmccar deleted the fix-lighthouse-highlight-test branch October 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues discovered through accessibility testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Fix Lighthouse failure - Foundations
3 participants