-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add textarea variant to checkbox component #3403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
precious-onyenaucheya-ons
added
Enhancement
Change of existing feature
Community backlog
An issue raised on the community backlog
labels
Oct 22, 2024
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor things, other than this looks good
src/components/checkboxes/example-checkboxes-with-text-area-and-character-limit.njk
Outdated
Show resolved
Hide resolved
...ts_checkboxes_example-checkboxes-with-text-area-and-character-limit_0_document_0_desktop.png
Outdated
Show resolved
Hide resolved
src/components/checkboxes/example-checkboxes-with-text-area-and-character-limit.njk
Outdated
Show resolved
Hide resolved
src/components/checkboxes/example-checkboxes-with-text-area-and-character-limit.njk
Outdated
Show resolved
Hide resolved
rmccar
requested changes
Oct 28, 2024
...nents/checkboxes/example-checkboxes-with-revealed-text-area-and-character-limit-expanded.njk
Outdated
Show resolved
Hide resolved
...nents/checkboxes/example-checkboxes-with-revealed-text-area-and-character-limit-expanded.njk
Outdated
Show resolved
Hide resolved
rmccar
changed the title
Add text-area variant to Checkbox component
Add text-area variant to checkbox component
Oct 28, 2024
Just need to remove the old vr screenshots from the PR now |
rmccar
requested changes
Oct 29, 2024
src/components/checkboxes/example-checkboxes-with-revealed-text-area.njk
Outdated
Show resolved
Hide resolved
src/components/checkboxes/example-checkboxes-with-revealed-text-area-expanded.njk
Outdated
Show resolved
Hide resolved
…t-area.njk Co-authored-by: rmccar <[email protected]>
…t-area-expanded.njk Co-authored-by: rmccar <[email protected]>
rmccar
reviewed
Oct 29, 2024
src/components/checkboxes/example-checkboxes-with-revealed-text-area-expanded.njk
Outdated
Show resolved
Hide resolved
adi-unni
approved these changes
Oct 29, 2024
rmccar
approved these changes
Oct 29, 2024
rmccar
changed the title
Add text-area variant to checkbox component
Add textarea variant to checkbox component
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes #3402
This PR introduces a new variant of the Checkboxes component. The new variant includes an integrated text area that allows users to input text, with a character limit checker to ensure the input doesn't exceed the specified limit.
How to review this PR
Checklist
This needs to be completed by the person raising the PR.