Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textarea variant to checkbox component #3403

Merged
merged 10 commits into from
Oct 29, 2024

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Oct 22, 2024

What is the context of this PR?

Fixes #3402

This PR introduces a new variant of the Checkboxes component. The new variant includes an integrated text area that allows users to input text, with a character limit checker to ensure the input doesn't exceed the specified limit.

How to review this PR

  • Check that text area variant has been added with a character limit checker
  • Check that all unit and visual tests pass

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@precious-onyenaucheya-ons precious-onyenaucheya-ons added Enhancement Change of existing feature Community backlog An issue raised on the community backlog labels Oct 22, 2024
@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team October 22, 2024 13:36
@precious-onyenaucheya-ons precious-onyenaucheya-ons linked an issue Oct 22, 2024 that may be closed by this pull request
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit fcc8fe9
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/6721554b4e67590008084330
😎 Deploy Preview https://deploy-preview-3403--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@rmccar rmccar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor things, other than this looks good

@rmccar rmccar changed the title Add text-area variant to Checkbox component Add text-area variant to checkbox component Oct 28, 2024
@rmccar
Copy link
Contributor

rmccar commented Oct 28, 2024

Just need to remove the old vr screenshots from the PR now

@rmccar rmccar changed the title Add text-area variant to checkbox component Add textarea variant to checkbox component Oct 29, 2024
@rmccar rmccar merged commit 25dcf1b into main Oct 29, 2024
39 checks passed
@rmccar rmccar deleted the feature/3402/checkbox-with-revealed-text-area branch October 29, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community backlog An issue raised on the community backlog Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox with revealed text area
4 participants