Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove space from button newWindowDescription #3363

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Sep 19, 2024

What is the context of this PR?

Fixes: #3364

Remove extra space from html when newWindowDescription is set

How to review this PR

  • Test example-button-new-window button example with and without screen reader
  • Check space is gone from html

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar added the Bug Something isn't working label Sep 19, 2024
@rmccar rmccar self-assigned this Sep 19, 2024
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 250dad1
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66ec087fa1a03e0008bc3820
😎 Deploy Preview https://deploy-preview-3363--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar merged commit 82265a8 into main Sep 19, 2024
8 of 9 checks passed
@rmccar rmccar deleted the remove-space-from-button-newWindowDescription branch September 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using newWindowDescription with the button component has extra space
3 participants