Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lighthouse files to git ignore #3354

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Sep 16, 2024

What is the context of this PR?

Fixes: #3352

This adds the temp files from running the lighthouse tests locally to git ignore

How to review this PR

Run lighthouse locally with ./lighthouse/lighthouse.sh and check there aren't any files that get added to your commit when you run git add -A

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar self-assigned this Sep 16, 2024
@rmccar rmccar added the Tech improvements Tech debt, cleanup, code standardisation etc. label Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit b559525
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66e98c7dc7ed710008e77d14
😎 Deploy Preview https://deploy-preview-3354--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alessioventuriniAND alessioventuriniAND requested a review from a team September 16, 2024 08:40
@rmccar rmccar merged commit 1e4c58d into main Sep 17, 2024
9 checks passed
@rmccar rmccar deleted the add-lighthouse-files-to-git-ignore branch September 17, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lighthouse temporary files to .gitignore file
4 participants