Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format and rename test examples file #3343

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Format and rename test examples file #3343

merged 5 commits into from
Sep 13, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Sep 12, 2024

What is the context of this PR?

Fixes: #3344

This PR updates the _test_examples.js file name to _test-examples.js which more closely matches the naming convention we have used for other files. It also updates the file to be 4 space indented to also match other files in the repo.

Has been tested locally by running the VR tests that have been skipped in the actions.

How to review this PR

  • Tests pass
  • Changes make sense

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar self-assigned this Sep 12, 2024
@rmccar rmccar added the Tech improvements Tech debt, cleanup, code standardisation etc. label Sep 12, 2024
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 3062f51
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66e43f96acf990000961a289
😎 Deploy Preview https://deploy-preview-3343--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar requested a review from a team September 12, 2024 10:46
@rmccar rmccar merged commit 3c2ff03 into main Sep 13, 2024
10 checks passed
@rmccar rmccar deleted the format-test-examples-file branch September 13, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test examples file needs formatting and renaming
4 participants