Ensure list item custom attributes are always set on list item #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ent when only one list item
…thub.com:ONSdigital/design-system into set-custom-list-attributes-on-list-item-not-link
alessioventuriniAND
approved these changes
Sep 11, 2024
rmccar
force-pushed
the
set-custom-list-attributes-on-list-item-not-link
branch
2 times, most recently
from
16b71e4 to
98eacf1
Compare
precious-onyenaucheya-ons
approved these changes
Sep 12, 2024
rmccar
restored the
set-custom-list-attributes-on-list-item-not-link
branch
rmccar
added a commit
that referenced
this pull request
Oct 9, 2024
rmccar
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Standardise setting heading level across components #3111 * Update param names to camel case naming standard #3188 * Renamed utility class from ons-grid--flex to ons-grid-flex #3268 * Removed metadata component #3275 * Remove call to action component and all references #3143 * Update parameter from UnreadLink to UnreadLinkUrl in Message component #3290 * Update parameter subject from text to object type in Message list component #3291 * Add option for additional logo in footer #3227 * Update parameter from link to text in Footer Component #3294 * Update parameter name from url to src in Image Component #3293 * Update parameter names from LogoImage and LogoURL to image and url a in header component #3292 * Update parameter name from url to linkUrl in feedback component #3295 * Rename summary component parameters #3224 * Refactor timeline macro for compatibility with Jinja2 templates #3180 * Update parameter names in document list component #3299 * Update param name settingsLinkTextURL to settingsLinkURL in Cookies Banner component #3300 * Update parameter names in card component #3303 * Update parameter from linkText to text in external link component #3304 * Update param name from title to text in section navigation component #3305 * Update parameter from linkText to videoLinkText in Video Component #3306 * Update parameter from manualLink to manualLinkUrl in Address Input component #3307 * Ensure list item custom attributes are always set on list item #3336 * Rename items summary param for compatibility with Jinja #3382 * Update DS components to ensure compatibility with Jinja #3380 * Rename html OGL Link param to current naming standard #3379 * Format migration guide #3377 * Introduction of new spacing grid #3285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #3337
Removes the deprecation introduced as part of the custom attribute changes to the list component in #3333. In that PR to avoid breaking changes some temporary code needed to put in to continue allowing custom attributes to be set on links within list items. This PR makes the changes so that list item custom attributes are now always set on the list item element rather than the link if there is a link in the list item and on the list item if there is no link. This means the functionality is more consistent. On lists where there is only one item the attribute is set on the paragraph element along with any list attributes.
How to review this PR
Test list component setting a different combinations of list and list item custom attributes, with and without url, single list item and multiple list items, single attribute and multiple attributes. Making sure that when there are multiple list items the attributes are always set on the
<li>element whetherurlis set or not and when there is a single item that all attributes are set on the<p>element.Checklist
This needs to be completed by the person raising the PR.