Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor browser banner test file to new format #3330

Merged
merged 18 commits into from
Sep 17, 2024
Merged

Refactor browser banner test file to new format #3330

merged 18 commits into from
Sep 17, 2024

Conversation

SriHV
Copy link
Contributor

@SriHV SriHV commented Sep 5, 2024 •
edited by rmccar
Loading

What is the context of this PR?

138

Refactored the browser-banner macro.spec file as per the new format.

How to review this PR

Ask yourself....

  • Do we need any additional tests?
  • Are the tests descriptions clear?
  • Does the order of the test document make sense?
  • Is it internally consistent?
  • Is it consistent with the guidelines for test refactoring?

run this test command to view the test results:
yarn test --testNamePattern="FOR: browser-banner"

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@SriHV SriHV self-assigned this Sep 5, 2024
@SriHV SriHV requested a review from a team September 5, 2024 12:52
@netlify Netlify
Copy link

netlify bot commented Sep 5, 2024 •
edited
Loading

✅ Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 576602d
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66e9441e56f80e0008ab9bbd
😎 Deploy Preview https://deploy-preview-3330--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SriHV SriHV linked an issue Sep 5, 2024 that may be closed by this pull request
Testing refactor - Browser banner ONSdigital/design-team#138
Closed
@SriHV SriHV added the Tech improvements Tech debt, cleanup, code standardisation etc. label Sep 5, 2024
@SriHV SriHV marked this pull request as ready for review September 5, 2024 12:53
SriHV and others added 9 commits September 13, 2024 11:41
@SriHV @rmccar
Update src/components/browser-banner/_macro.spec.js
33ee3d2 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/browser-banner/_macro.spec.js
644165e 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/browser-banner/_macro.spec.js
7c48d73 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/browser-banner/_macro.spec.js
3756da5 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/browser-banner/_macro.spec.js
da7f900 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/browser-banner/_macro.spec.js
0bd8869 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/browser-banner/_macro.spec.js
b4556b4 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/browser-banner/_macro.spec.js
49aea08 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/browser-banner/_macro.spec.js
2630194 
Co-authored-by: rmccar <[email protected]>
@alessioventuriniAND alessioventuriniAND merged commit acfb5a7 into main Sep 17, 2024
9 checks passed
@alessioventuriniAND alessioventuriniAND deleted the enhancement/138/testing-refactor-browser-banner branch September 17, 2024 10:56
@rmccar rmccar changed the title Refactor browser banner test file to new format Refactor Browser banner test file to new format Nov 8, 2024
@rmccar rmccar changed the title Refactor Browser banner test file to new format Refactor browser banner test file to new format Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessioventuriniAND alessioventuriniAND alessioventuriniAND approved these changes

@rmccar rmccar rmccar approved these changes

Assignees

@SriHV SriHV

Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing refactor - Browser banner
3 participants
@SriHV @rmccar @alessioventuriniAND