-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Autosuggest component test file to new format #3327
Refactor Autosuggest component test file to new format #3327
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some more work needs to be done here, use one of the other PRs as a template. We are missing the "FOR" and "THEN" in some cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ive realised we are missing tests for the language and resultsThreshold params. I think we should add these
6096db1
to
9915198
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to check the required the params in the documentation some of these in the required describe aren't required still. Also the "params none" describe you've added actually passes in a lot of params because it uses EXAMPLE_AUTOSUGGEST
. I don't think we need this describe though, we should be testing these things with the required params because we expect those params to be passed in
b7fe5c4
to
1f43ccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few tests I thought that could be added to improve our coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of typos
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
What is the context of this PR?
Fixes: ONSdigital/design-team#134
This PR involves refactoring of the autosuggest test document to follow the Given, When, Then testing approach.
How to review this PR
Functionality:
Does this testing refactor meet the following success criteria:
Look at the refactored code in relation to:
Checklist
This needs to be completed by the person raising the PR.