Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Accordion component test file to new format #3320

Merged
merged 17 commits into from
Sep 27, 2024
Merged

Refactor Accordion component test file to new format #3320

merged 17 commits into from
Sep 27, 2024

Conversation

balibirchlee
Copy link
Contributor

@balibirchlee balibirchlee commented Aug 28, 2024 •
edited by rmccar
Loading

What is the context of this PR?

Fixes #131 in the design team issues board

I've also added some tests that I thought were missing

How to review this PR

Ask yourself....

  • Do we need any additional tests?
  • Are the tests descriptions clear?
  • Does the order of the test document make sense?
  • Is it internally consistent?
  • Is it consistent with the guidelines for test refactoring?
  • run this test command to view the test results:
  • yarn test --testNamePattern="FOR: Macro: Accordion"

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@balibirchlee balibirchlee requested a review from a team August 28, 2024 14:11
@balibirchlee balibirchlee self-assigned this Aug 28, 2024
@balibirchlee balibirchlee linked an issue Aug 28, 2024 that may be closed by this pull request
Testing refactor - Accordion ONSdigital/design-team#131
Closed
@netlify Netlify
Copy link

netlify bot commented Aug 28, 2024 •
edited
Loading

✅ Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 422198d
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66f6b6a413ba38000882afb3
😎 Deploy Preview https://deploy-preview-3320--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@balibirchlee balibirchlee added the Tech improvements Tech debt, cleanup, code standardisation etc. label Aug 28, 2024
rmccar
rmccar requested changes Sep 5, 2024
View reviewed changes
src/components/accordion/_macro.spec.js Outdated Show resolved Hide resolved
src/components/accordion/_macro.spec.js Outdated Show resolved Hide resolved
@rmccar rmccar merged commit 2ed65e3 into main Sep 27, 2024
42 checks passed
@rmccar rmccar deleted the enhancement/131/testing-refactor-accordion branch September 27, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessioventuriniAND alessioventuriniAND alessioventuriniAND approved these changes

@rmccar rmccar rmccar approved these changes

Assignees

@balibirchlee balibirchlee

Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing refactor - Accordion
3 participants
@balibirchlee @rmccar @alessioventuriniAND