Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Address output component test file to new format #3308

Merged
merged 36 commits into from
Nov 8, 2024
Merged

Refactor Address output component test file to new format #3308

merged 36 commits into from
Nov 8, 2024

Conversation

SriHV
Copy link
Contributor

@SriHV SriHV commented Aug 21, 2024 •
edited by rmccar
Loading

What is the context of this PR?

133

Refactored the address-output macro.spec file as per the new format.

How to review this PR

Ask yourself....

  • Do we need any additional tests?
  • Are the tests descriptions clear?
  • Does the order of the test document make sense?
  • Is it internally consistent?
  • Is it consistent with the guidelines for test refactoring?

run this test command to view the test results:
yarn test --testNamePattern="FOR: address-output"

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@netlify Netlify
Copy link

netlify bot commented Aug 21, 2024 •
edited
Loading

✅ Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit f7fdf05
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/672e119b57762400080bd590
😎 Deploy Preview https://deploy-preview-3308--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SriHV SriHV self-assigned this Aug 21, 2024
@SriHV SriHV linked an issue Aug 21, 2024 that may be closed by this pull request
Testing refactor - Address output ONSdigital/design-team#133
Closed
@SriHV SriHV added the Tech improvements Tech debt, cleanup, code standardisation etc. label Aug 21, 2024
@SriHV SriHV requested a review from a team August 21, 2024 15:10
@SriHV SriHV marked this pull request as ready for review August 21, 2024 15:11
balibirchlee
balibirchlee suggested changes Aug 28, 2024
View reviewed changes
src/components/address-output/_macro.spec.js Outdated Show resolved Hide resolved
src/components/address-output/_macro.spec.js Outdated Show resolved Hide resolved
src/components/address-output/_macro.spec.js Outdated Show resolved Hide resolved
@rmccar rmccar changed the title Refactor address-output test file to new format Refactor address-output component test file to new format Sep 19, 2024
@rmccar rmccar changed the title Refactor address-output component test file to new format Refactor Address output component test file to new format Sep 27, 2024
SriHV and others added 20 commits September 30, 2024 15:24
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
999c4f7 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
ea2c0e5 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
fe023bb 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
317bffa 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
20cec66 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
4697127 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
12d8e0c 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
7aff671 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
894d32d 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
3b4d693 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
a7f4253 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
2fb31fd 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
6e69fc8 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
389c41e 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
c810622 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
f0a1ca6 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
d50ec2b 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
d206b26 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/address-output/_macro.spec.js
5c5b3bf 
Co-authored-by: rmccar <[email protected]>
@SriHV
Merge branch 'main' into enhancement/133/testing-refactor-address-output
eb0f189
@rmccar rmccar added the Do not merge Don't merge this PR until this label is removed label Oct 2, 2024
@rmccar rmccar removed the Do not merge Don't merge this PR until this label is removed label Oct 9, 2024
@SriHV SriHV merged commit af04adf into main Nov 8, 2024
25 checks passed
@SriHV SriHV deleted the enhancement/133/testing-refactor-address-output branch November 8, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balibirchlee balibirchlee balibirchlee requested changes

@alessioventuriniAND alessioventuriniAND alessioventuriniAND approved these changes

@rmccar rmccar rmccar approved these changes

Assignees

@SriHV SriHV

Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing refactor - Address output
4 participants
@SriHV @rmccar @alessioventuriniAND @balibirchlee