-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parameter subject from text to object type in Message list component #3291
Merged
alessioventuriniAND
merged 2 commits into
major-release
from
enhancement/86/change-parameter-name-convention-messageList
Sep 5, 2024
Merged
Update parameter subject from text to object type in Message list component #3291
alessioventuriniAND
merged 2 commits into
major-release
from
enhancement/86/change-parameter-name-convention-messageList
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SriHV
added
Breaking changes
This PR contains at least one breaking change
Do not merge
Don't merge this PR until this label is removed
labels
Aug 12, 2024
2 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the description to include a description for the breaking change
SriHV
changed the title
Change Parameter Naming convention in Message list
Update Parameter Naming convention in Message list
Aug 13, 2024
precious-onyenaucheya-ons
approved these changes
Aug 14, 2024
rmccar
requested changes
Aug 15, 2024
SriHV
changed the title
Update Parameter Naming convention in Message list
Update parameter subject from text to object convention in Message list component
Aug 15, 2024
SriHV
changed the title
Update parameter subject from text to object convention in Message list component
Update parameter subject from text to object type in Message list component
Aug 15, 2024
rmccar
approved these changes
Aug 16, 2024
alessioventuriniAND
removed
the
Do not merge
Don't merge this PR until this label is removed
label
Sep 5, 2024
alessioventuriniAND
deleted the
enhancement/86/change-parameter-name-convention-messageList
branch
September 5, 2024 10:55
This was referenced Sep 10, 2024
Closed
Merged
rmccar
pushed a commit
that referenced
this pull request
Oct 9, 2024
rmccar
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Standardise setting heading level across components #3111 * Update param names to camel case naming standard #3188 * Renamed utility class from ons-grid--flex to ons-grid-flex #3268 * Removed metadata component #3275 * Remove call to action component and all references #3143 * Update parameter from UnreadLink to UnreadLinkUrl in Message component #3290 * Update parameter subject from text to object type in Message list component #3291 * Add option for additional logo in footer #3227 * Update parameter from link to text in Footer Component #3294 * Update parameter name from url to src in Image Component #3293 * Update parameter names from LogoImage and LogoURL to image and url a in header component #3292 * Update parameter name from url to linkUrl in feedback component #3295 * Rename summary component parameters #3224 * Refactor timeline macro for compatibility with Jinja2 templates #3180 * Update parameter names in document list component #3299 * Update param name settingsLinkTextURL to settingsLinkURL in Cookies Banner component #3300 * Update parameter names in card component #3303 * Update parameter from linkText to text in external link component #3304 * Update param name from title to text in section navigation component #3305 * Update parameter from linkText to videoLinkText in Video Component #3306 * Update parameter from manualLink to manualLinkUrl in Address Input component #3307 * Ensure list item custom attributes are always set on list item #3336 * Rename items summary param for compatibility with Jinja #3382 * Update DS components to ensure compatibility with Jinja #3380 * Rename html OGL Link param to current naming standard #3379 * Format migration guide #3377 * Introduction of new spacing grid #3285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking changes
This PR contains at least one breaking change
Enhancement
Change of existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
#86...
As per the ticket tech notes, subject is made an object with text and url params.
Updated _macro-options.md file
BREAKING CHANGES
Description of change: In Message List component,
subject
parameter is changed to an object which containstext
andurl
parameter.url
parameter is moved inside subjectReason for change: This update helps to standardise the parameter names within the project.
Migration steps:
subject
parameter, and includetext
andurl
within thesubject
.Click for example
How to review this PR
Check that all the references to the parameters have been updated
Check that all the visual tests pass
Checklist
This needs to be completed by the person raising the PR.