Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Puppeteer to v22 #3266

Merged
merged 75 commits into from
Sep 9, 2024
Merged

Update Puppeteer to v22 #3266

merged 75 commits into from
Sep 9, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Jul 12, 2024

What is the context of this PR?

Fixes: ONSdigital/design-team#207

Updates to Puppeteer v22. Also fixes the awaitForTimeout breaking change which is now no longer supported.

We may want to replace some of these waits with waitForSelector at some point which will be a better way of waiting.

How to review this PR

Tests pass

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar added the Tech improvements Tech debt, cleanup, code standardisation etc. label Jul 12, 2024
@rmccar rmccar self-assigned this Jul 12, 2024
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 01610be
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66deffb92f3c8000089d6aaf
😎 Deploy Preview https://deploy-preview-3266--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar marked this pull request as draft July 13, 2024 12:29
@rmccar rmccar marked this pull request as ready for review September 9, 2024 14:06
@rmccar rmccar requested a review from a team September 9, 2024 14:55
@rmccar rmccar merged commit 07f4ee1 into main Sep 9, 2024
10 checks passed
@rmccar rmccar deleted the update-puppeteer branch September 9, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] VR testing issue
3 participants