-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct width of checkboxes with drop down select #3212
Merged
alessioventuriniAND
merged 7 commits into
main
from
fix/3181/aligns-checkbox-widths-for-revealed-selects
Jun 3, 2024
Merged
Correct width of checkboxes with drop down select #3212
alessioventuriniAND
merged 7 commits into
main
from
fix/3181/aligns-checkbox-widths-for-revealed-selects
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
changed the title
correct width of checkboxes with drop down select
Correct width of checkboxes with drop down select
May 24, 2024
precious-onyenaucheya-ons
approved these changes
May 28, 2024
alessioventuriniAND
approved these changes
May 29, 2024
rmccar
approved these changes
May 30, 2024
alessioventuriniAND
deleted the
fix/3181/aligns-checkbox-widths-for-revealed-selects
branch
June 3, 2024 14:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #3181
Details of changes:
Reasoning for decisions:
min-width
rather thanwidth
to prevent it restricting the size of the feedback patterns which are wider than 25rem.:has(select)
to identify when a radio/checkbox has a hidden select component, then uses:first-child
to ensure it's only set on one parent element of that select, rather than all of them (which creates visual errors).Relevant issues/discussions:
How to review this PR
Visual inspection:
Components/Patterns to Check
Actions
Desired Behaviour
Relevant tests:
Special attention:
Checklist
This needs to be completed by the person raising the PR.