Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Tech improvements" label to label checker #3203

Merged
merged 1 commit into from
May 16, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented May 13, 2024

What is the context of this PR?

Fixes: #3184

This PR adds the "Tech improvements" label which can be used for tech debt and small technical improvements

How to review this PR

Check that change makes sense

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar added the CI/CD This PR makes changes to the CI/CD process label May 13, 2024
@rmccar rmccar self-assigned this May 13, 2024
@rmccar rmccar requested a review from a team May 13, 2024 15:49
Copy link

netlify bot commented May 13, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 2c381d2
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66423660bd75260008ddd22f
😎 Deploy Preview https://deploy-preview-3203--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@balibirchlee
Copy link
Contributor

Am I right that enhancements effect the functionality whilst tech improvements don't?

Also wouldn't mind discussing the purpose and use of labels in a tech session, especially in relation to some of the research I've been doing (similar to types from conventional commits)

But this is just me trying to better understand it all!

@rmccar
Copy link
Contributor Author

rmccar commented May 14, 2024

Am I right that enhancements effect the functionality whilst tech improvements don't?

Also wouldn't mind discussing the purpose and use of labels in a tech session, especially in relation to some of the research I've been doing (similar to types from conventional commits)

But this is just me trying to better understand it all!

Yeah pretty much, I would say enhancements add or improve functionality from a user perspective but tech improvements don't really make a difference to the user and are more like tech debt. But yeah I think it would be good to discuss these labels and what sections we want them to go into in the release documentation etc as part of the work you are doing.

@rmccar rmccar merged commit c45395a into main May 16, 2024
12 checks passed
@rmccar rmccar deleted the add-tech-improvements-to-label-checker branch May 16, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD This PR makes changes to the CI/CD process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and update the label checker github action
5 participants