Remove onsCollapsible #2895
Merged
Remove onsCollapsible #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccar
added
Breaking changes
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
precious-onyenaucheya-ons
approved these changes
Nov 10, 2023
alessioventuriniAND
approved these changes
Nov 10, 2023
adi-unni
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #2868
onsCollapsible has been replaced with onsDetails we kept onsCollapsible as backwards compatibility for a time. This PR is to now fully remove onsCollapsible.
BREAKING CHANGE
onsCollapsible is no longer able to be used, services should now use onsDetails instead. To fix the breaking change where onsCollapsible is being used rename that macro call to use onsDetails and anything targets the collapsible css classes will also have to be updated. Other than that the configuration between the two macros should be the same.
How to review this PR
Check that all references to onsCollapsible have been removed
Checklist
This needs to be completed by the person raising the PR.