Feature/add tests for autosuggest component #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
precious-onyenaucheya-ons
requested review from
rmccar,
adi-unni and
alessioventuriniAND
precious-onyenaucheya-ons
added
the
Tech improvements
alessioventuriniAND
approved these changes
Nov 10, 2023
adi-unni
approved these changes
Nov 10, 2023
precious-onyenaucheya-ons
deleted the
feature/add-tests-for-autosuggest-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
I added an example header with both navigation and search properties. Also added tests to check if the search is rendered correctly
How to review this PR
Check that ll tests added are passed
Checklist
This needs to be completed by the person raising the PR.