Add max width to paragraphs #2887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
precious-onyenaucheya-ons
added
the
Accessibility
precious-onyenaucheya-ons
requested review from
rmccar and
alessioventuriniAND
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
reviewed
Nov 6, 2023
There was a problem hiding this comment.
I've noticed a few things looking at the visual test results that look odd to me now, and that we might need to do something about. Might be something to discuss with Joe to see what he thinks.
Panels and interviewers notes look too wide for the content and probably also need to be limited:
Featured articles now look a bit too narrow for the page and should probably still be full width:
Should text areas still be this wide?:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
fixes https://github.com/ONSdigital/ons-service-manual-website/issues/64
I have set max width to 685px for paragraphs, lists and headings in the design system
How to review this PR
Check that the width of all paragraphs, list and headings in the DS does not exceed 685ox.
Checklist
This needs to be completed by the person raising the PR.