Use node-version-file in Github actions to improve node version setting #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
requested review from
alessioventuriniAND,
adi-unni and
precious-onyenaucheya-ons
precious-onyenaucheya-ons
approved these changes
Nov 9, 2023
alessioventuriniAND
approved these changes
Nov 10, 2023
adi-unni
approved these changes
Nov 10, 2023
rmccar
deleted the
enhancement/2885/use-node-version-file-in-github-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #2885
Updates the Github actions to use node-version-file and not need the manual read from .nvmrc file step
Also fixes some code formatting in various files
How to review this PR
Check that github actions are getting the correct node version
Checklist
This needs to be completed by the person raising the PR.